Skip to content

Make an empty DiffSync instance evaluate to True. - #114

Closed
Kircheneer wants to merge 10 commits into
next-2.0from
lk-#84
Closed

Make an empty DiffSync instance evaluate to True.#114
Kircheneer wants to merge 10 commits into
next-2.0from
lk-#84

Conversation

@Kircheneer

Copy link
Copy Markdown
Contributor

Fixes#84

@glennmatthews

Copy link
Copy Markdown
Collaborator

I'm curious as to whether this should be considered a breaking change - i.e. are there any existing users of the library that rely on the current truthiness behavior?

@Kircheneer

Copy link
Copy Markdown
ContributorAuthor

As discussed this really should warrant a major version increase and as such will have to be delayed until we have more breaking changes.

@KircheneerKircheneer self-assigned this Jun 29, 2022
@KircheneerKircheneer added this to the 2.0.0 milestone Jun 29, 2022
@Kircheneer
Kircheneer changed the base branch from develop to next-2.0August 18, 2023 17:28
@KircheneerKircheneer mentioned this pull request Jan 22, 2024
7 tasks
@KircheneerKircheneer mentioned this pull request Jan 22, 2024
2 tasks
@jdrew82
jdrew82 deleted the lk-#84 branch March 27, 2025 22:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty DiffSync instance evaluates as false

2 participants

@Kircheneer@glennmatthews