Skip to content

Add 'skip' counter to diff.summary() - #168

Merged
Kircheneer merged 4 commits into
networktocode:developfrom
ubaumann:develop
Oct 18, 2022
Merged

Add 'skip' counter to diff.summary()#168
Kircheneer merged 4 commits into
networktocode:developfrom
ubaumann:develop

Conversation

@ubaumann

@ubaumannubaumann commented Oct 14, 2022

Copy link
Copy Markdown
Contributor

Closes#89

Adding the processed model counter to the Diff object to be able to calculate the number of skipped models.

@ubaumann

ubaumann commented Oct 14, 2022

Copy link
Copy Markdown
ContributorAuthor

This implementation only works on the Diff object and not with the DiffElement. At the moment <Diff>.summary() returns a dict with the "skip" key and <DiffElement>.summer() returns a dict without the "skip" key. So I am not sure if this could let to some confusion.

My first idea was to implement the solution in the DiffElement class, but when a model is skipped, there is no DiffElement returned. Changing this would probably bring more changes, so I decided to first make a simple solution and see what you think about.

I appreciate feedback and can change the code accordingly.

chadell
chadell reviewed Oct 15, 2022
View reviewed changes

@chadellchadell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the approach seems reasonable to me, only 2 questions.

Comment threaddiffsync/diff.py
Comment threaddiffsync/diff.py
chadell
chadell previously approved these changes Oct 17, 2022
View reviewed changes

@chadellchadell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kircheneer
Kircheneer suggested changes Oct 17, 2022
View reviewed changes

@KircheneerKircheneer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me bar this comment. 🥳

Kircheneer
Kircheneer approved these changes Oct 17, 2022
View reviewed changes

@KircheneerKircheneer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kircheneer
Kircheneer merged commit 538b661 into networktocode:developOct 18, 2022
itdependsnetworks pushed a commit to itdependsnetworks/diffsync that referenced this pull request Oct 30, 2022
@ubaumann@itdependsnetworks
Add 'skip' counter to diff.summary() (networktocode#168)
b1d128a
* Add 'skip' to diff.summary()
* Fix location of variable and comment
* Update summary in example 6
* Add comment to skip callculation in diff.summary()
Kircheneer pushed a commit that referenced this pull request Nov 8, 2022
@ubaumann@Kircheneer
Add 'skip' counter to diff.summary() (#168)
225da0a
* Add 'skip' to diff.summary()
* Fix location of variable and comment
* Update summary in example 6
* Add comment to skip callculation in diff.summary()
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glennmatthewsglennmatthewsAwaiting requested review from glennmatthewsglennmatthews is a code owner
2 more reviewers
@KircheneerKircheneerKircheneer approved these changes
@chadellchadellchadell left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a new skip counter in diff.summary()

3 participants

@ubaumann@Kircheneer@chadell