Skip to content

Add documentation around ordering - #170

Merged
Kircheneer merged 4 commits into
networktocode:developfrom
itdependsnetworks:order-docs
Oct 21, 2022
Merged

Add documentation around ordering#170
Kircheneer merged 4 commits into
networktocode:developfrom
itdependsnetworks:order-docs

Conversation

@itdependsnetworks

@itdependsnetworksitdependsnetworks commented Oct 18, 2022

Copy link
Copy Markdown
Contributor

No description provided.

Kircheneer
Kircheneer suggested changes Oct 18, 2022
View reviewed changes

@KircheneerKircheneer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot, this answers a question I had in the beginning as well. Since we have dropped Python 3.6 support we are also safe to rely on the fact that dictionaries are ordered now, so that's good.

Comment threaddocs/source/getting_started/01-getting-started.md
Comment threaddocs/source/getting_started/01-getting-started.md
Comment threaddocs/source/getting_started/01-getting-started.md
Comment threaddocs/source/getting_started/01-getting-started.md Outdated
Comment threaddocs/source/getting_started/01-getting-started.md Outdated
glennmatthews
glennmatthews reviewed Oct 18, 2022
View reviewed changes
Comment threaddocs/source/getting_started/01-getting-started.md Outdated
Comment threaddocs/source/getting_started/01-getting-started.md Outdated
Comment threaddocs/source/getting_started/01-getting-started.md
Comment threaddocs/source/getting_started/01-getting-started.md
Kircheneer
Kircheneer reviewed Oct 19, 2022
View reviewed changes
Comment threaddocs/source/getting_started/01-getting-started.md
Kircheneer
Kircheneer previously approved these changes Oct 20, 2022
View reviewed changes
glennmatthews
glennmatthews previously approved these changes Oct 20, 2022
View reviewed changes
Comment threaddocs/source/getting_started/01-getting-started.md Outdated
@itdependsnetworks@glennmatthews
Update docs/source/getting_started/01-getting-started.md
8490fc8
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
@Kircheneer
Kircheneer merged commit b2c57e2 into networktocode:developOct 21, 2022
Kircheneer pushed a commit that referenced this pull request Nov 8, 2022
@itdependsnetworks@glennmatthews@Kircheneer
Add documentation around ordering (#170)
ade3f33
* Add documentation around ordering
* update note
* Update docs and add diag
* Update docs/source/getting_started/01-getting-started.md
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glennmatthewsglennmatthewsglennmatthews approved these changes
@chadellchadellAwaiting requested review from chadell
+1 more reviewer
@KircheneerKircheneerKircheneer left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@itdependsnetworks@glennmatthews@Kircheneer