Skip to content

Update docker, add methods to load from dictionary, get tree traversa… - #174

Merged
Kircheneer merged 6 commits into
networktocode:developfrom
itdependsnetworks:new_meth
Nov 2, 2022
Merged

Update docker, add methods to load from dictionary, get tree traversa…#174
Kircheneer merged 6 commits into
networktocode:developfrom
itdependsnetworks:new_meth

Conversation

@itdependsnetworks

@itdependsnetworksitdependsnetworks commented Oct 30, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

…l, and update docs

  • Update docker since it was failing with my build (needed gcc)
  • Updated poetry to accommodate other built issues with redislite
  • Added method to load from dictionary
  • Added method to show the traversal of tree, and docs to go with
  • Added method to get one or none

@itdependsnetworks

itdependsnetworks commented Oct 30, 2022

Copy link
Copy Markdown
ContributorAuthor

Note that mypy does not support recursive typing for now, hence the usage of Any.

glennmatthews
glennmatthews reviewed Oct 31, 2022
View reviewed changes
Comment threaddiffsync/__init__.py Outdated
Comment threaddiffsync/__init__.py Outdated
Comment threaddiffsync/__init__.py Outdated
Comment threaddiffsync/__init__.py Outdated
Comment threaddiffsync/utils.py Outdated
Comment threaddiffsync/utils.py Outdated
Comment threaddocs/source/getting_started/01-getting-started.md Outdated
Comment threaddiffsync/__init__.py Outdated
Comment threadtests/unit/test_diffsync.py Outdated
Comment threadtests/unit/test_diffsync.py
Kircheneer
Kircheneer reviewed Nov 1, 2022
View reviewed changes
Comment threaddiffsync/__init__.py Outdated
Kircheneer
Kircheneer reviewed Nov 1, 2022
View reviewed changes
Comment threaddiffsync/utils.py Outdated
Kircheneer
Kircheneer reviewed Nov 1, 2022
View reviewed changes
Comment threaddiffsync/utils.py Outdated
Kircheneer
Kircheneer reviewed Nov 1, 2022
View reviewed changes
Comment threaddiffsync/utils.py Outdated
Kircheneer
Kircheneer suggested changes Nov 1, 2022
View reviewed changes

@KircheneerKircheneer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! I have a couple type hinting nitpicks but apart from that I like it.

@Kircheneer

Kircheneer commented Nov 1, 2022

Copy link
Copy Markdown
Contributor

Note that mypy does not support recursive typing for now, hence the usage of Any.

I wasn't able to spot usage of typing.Any anywhere except in a function docstring (where the type was not equivalent to that in the signature). I say we just drop new type hints from docstrings (including the ones from this PR) and I make sure I remove all existing ones with #175 ?

@Kircheneer
Kircheneer self-requested a review November 2, 2022 09:46
Kircheneer
Kircheneer approved these changes Nov 2, 2022
View reviewed changes

@KircheneerKircheneer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kircheneer
Kircheneer merged commit 6f022dd into networktocode:developNov 2, 2022
@chadellchadell mentioned this pull request Nov 7, 2022
Merged
Kircheneer pushed a commit that referenced this pull request Nov 8, 2022
@itdependsnetworks@glennmatthews@Kircheneer
Update docker, add methods to load from dictionary, get tree traversa… (
fffae73
#174)
* Update docker, add methods to load from dictionary, get tree traversal, and update docs
* Apply suggestions from code review
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
* Additional recommended updates for loop efficiency and using classmethod
* update docs
* mypy feedback
* lock poetry
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glennmatthewsglennmatthewsglennmatthews left review comments
@chadellchadellAwaiting requested review from chadell
+1 more reviewer
@KircheneerKircheneerKircheneer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@itdependsnetworks@Kircheneer@glennmatthews