Skip to content

Add methods for get or update instantiate_model - #182

Merged
Kircheneer merged 1 commit into
networktocode:developfrom
itdependsnetworks:instantiate_model
Nov 28, 2022
Merged

Add methods for get or update instantiate_model#182
Kircheneer merged 1 commit into
networktocode:developfrom
itdependsnetworks:instantiate_model

Conversation

@itdependsnetworks

@itdependsnetworksitdependsnetworks commented Nov 5, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@itdependsnetworks

itdependsnetworks commented Nov 5, 2022

Copy link
Copy Markdown
ContributorAuthor

Doh’, this doesn’t make sense. When I went to use this, I realized the method was conditionally adding. This is just redundant

@itdependsnetworks

itdependsnetworks commented Nov 5, 2022

Copy link
Copy Markdown
ContributorAuthor

Double Doh'!! ok, red herring, there was an issue, I didn't see where the code was actually issuing a self.add (it was nested more), so I thought it was adding.... it was :)

Kircheneer
Kircheneer suggested changes Nov 7, 2022
View reviewed changes
Comment threaddiffsync/store/__init__.py Outdated
Comment threaddiffsync/store/__init__.py Outdated
Comment threaddiffsync/store/__init__.py Outdated
Comment threaddiffsync/store/__init__.py Outdated
Comment threaddiffsync/store/__init__.py Outdated
Kircheneer
Kircheneer suggested changes Nov 23, 2022
View reviewed changes

@KircheneerKircheneer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, I just have two minor suggestions.

Comment threaddiffsync/store/__init__.py Outdated
Comment threaddiffsync/store/__init__.py
chadell
chadell approved these changes Nov 24, 2022
View reviewed changes

@chadellchadell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kircheneer
Kircheneer merged commit f6afd05 into networktocode:developNov 28, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glennmatthewsglennmatthewsAwaiting requested review from glennmatthewsglennmatthews is a code owner
2 more reviewers
@KircheneerKircheneerKircheneer approved these changes
@chadellchadellchadell approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@itdependsnetworks@Kircheneer@chadell