Uh oh!
There was an error while loading. Please reload this page.
Type hinting overhaul. - #219
Merged
Merged
Conversation
Kircheneerforce-pushed
the
typing-overhaul
branch
from
March 17, 2023 14:49
5b1f7c1 to
5a3bf7bCompareKircheneerforce-pushed
the
typing-overhaul
branch
2 times, most recently
from
March 17, 2023 14:53
70336ac to
b0dcde9CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| """Exception raised when trying to store a DiffSyncModel or DiffElement that is already being stored.""" | ||
| def __init__(self, message, existing_object, *args, **kwargs): | ||
| def __init__(self, message: str, existing_object: Union["DiffSyncModel", "DiffElement"], *args: Any, **kwargs: Any): |
Collaborator
There was a problem hiding this comment.
Should existing_object just be an Any?
ContributorAuthor
There was a problem hiding this comment.
What other than DiffSyncModel or DiffElement would we store in a store?
Uh oh!
There was an error while loading. Please reload this page.
Kircheneerforce-pushed
the
typing-overhaul
branch
from
March 20, 2023 09:49
b0dcde9 to
862fea9CompareKircheneerforce-pushed
the
typing-overhaul
branch
from
August 15, 2023 16:57
862fea9 to
75b6b19CompareKircheneer
commented
Aug 15, 2023
ContributorAuthor
Addressed all outstanding comments, rebased against develop and put it into a backwards-compatible state. Should be an easy-ish merge at this point I think? |
Kircheneerforce-pushed
the
typing-overhaul
branch
from
August 15, 2023 17:09
75b6b19 to
acea842Compare
Kircheneerforce-pushed
the
typing-overhaul
branch
from
August 15, 2023 17:14
acea842 to
4fa39b5CompareKircheneer
marked this pull request as ready for review
August 17, 2023 15:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#175. Things that happened here:
disallow_untyped_defsin mypy config inpyproject.tomlMappingwithDict,CollectionwithListandTextwithstr, because all our mappings are dicts anyway, collections are lists (3.9 could usedict/list, maybe we can drop 3.8 support with 2.0?) andTextis only needed for backwards compatibility with Python 2.x which we aren't offering