Uh oh!
There was an error while loading. Please reload this page.
Implement DiffSyncModelFlags.NATURAL_DELETION_ORDER. - #220
Conversation
456670e to
3e79a6aCompare3e79a6a to
58f4806CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
chadell
left a comment
There was a problem hiding this comment.
to me looks good, but I would make it the default (and sole) behavior
Kircheneer
commented
Mar 20, 2023
so @chadell your recommendation would be to drop this into 2.0 and make a backwards-incompatible change, changing the flag to be the default? |
chadell
commented
Mar 20, 2023
as I see it, this seems more a bugfix than a feature as this deletion mode is the one I would expect by default. Actually, I don't see the other use case. So, my approach would be to do not even define a flag for it. |
itdependsnetworks
commented
Mar 20, 2023
In agreement with Christian, it seemed odd to me to have this as a flag. In my mind, it should be handled the same way that order children is handled. https://diffsync.readthedocs.io/en/latest/core_engine/02-customize-diff-class.html?#change-the-order-in-which-the-element-are-being-processed |
Kircheneer
commented
Mar 20, 2023
Unfortunately you can't achieve this behaviour from this MR in a custom |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Kircheneer
commented
Apr 11, 2023
My plan is now:
|
Closes#97. Implement
DiffSyncModelFlags.NATURAL_DELETION_ORDERwhich handlesDiffSyncAction.DELETEelements differently by first deleting their children recursively before handling their parents.Open points