Skip to content

Extend sync_to|from to accept a Diff - #80

Merged
glennmatthews merged 6 commits into
networktocode:mainfrom
FragmentedPacket:76-sync-diff
Nov 22, 2021
Merged

Extend sync_to|from to accept a Diff#80
glennmatthews merged 6 commits into
networktocode:mainfrom
FragmentedPacket:76-sync-diff

Conversation

@FragmentedPacket

@FragmentedPacketFragmentedPacket commented Nov 14, 2021

Copy link
Copy Markdown
Contributor

Fixes#76

This allows a user to pass in an existing Diff object into sync_to|from to prevent another diff from being calculated.

  • Updated examples, docs, and tests.
  • Remove print statement within tests

glennmatthews
glennmatthews reviewed Nov 17, 2021
View reviewed changes
Comment threadexamples/01-multiple-data-sources/README.md Outdated
Comment threadexamples/03-remote-system/main.py
Comment threadtests/unit/test_diffsync.py
Comment threadtests/unit/test_diffsync.py
Comment threaddiffsync/__init__.py Outdated
Comment threaddiffsync/__init__.py Outdated
Comment threaddiffsync/__init__.py
FragmentedPacketand others added 5 commits November 20, 2021 14:53
@FragmentedPacket@glennmatthews
Update examples/01-multiple-data-sources/README.md
0d19468
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
@FragmentedPacket@glennmatthews
Update diffsync/__init__.py
9f88513
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
@FragmentedPacket@glennmatthews
Update diffsync/__init__.py
1482248
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
@FragmentedPacket
Add better testing. Add new exception if provided diff_class and diff…
4b804b8
… do not match.
@FragmentedPacket
Pylint fails within the pipeline, but not locally.
0bb0f0e
glennmatthews
glennmatthews approved these changes Nov 22, 2021
View reviewed changes

@glennmatthewsglennmatthews left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@glennmatthews
glennmatthews merged commit 92ceca9 into networktocode:mainNov 22, 2021
@FragmentedPacket
FragmentedPacket deleted the 76-sync-diff branch November 22, 2021 22:11
@glennmatthewsglennmatthews mentioned this pull request Dec 1, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glennmatthewsglennmatthewsglennmatthews approved these changes
@dgarrosdgarrosAwaiting requested review from dgarros

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extend sync_from and sync_to to accept an existing diff

2 participants

@FragmentedPacket@glennmatthews