Example 5: PeeringDB to Nautobot example

[chadell]

Contributing with this example: https://github.com/chadell/playground-diffsync

[chadell]

@glennmatthews , I am not sure if the example is good for the CI, because it is actually updating the demo.nautobot.com at every run (it creates some sites and regions)... I leave at your criteria
BTW, do not merge it before 29 of November, I'm doing a workshop with the library and I prefer to not include this example already 😄

[glennmatthews]

Good thought. Maybe make the main.py (which it looks like you may not have committed to Git?) only run up to the diff.summary() and not perform the final sync_from() step?

Or alternately maybe we should leave this out of the CI altogether since it's not self-contained but is interacting with external systems. That might be wiser.

[chadell]

Yes, I believe that in this case is wiser to skip the test as being dependent on external systems. I added the main.py as reference

[dgarros]

Looks good to me overall,
it's not a blocker but I think if we should leverage pynautobot whenever possible, it makes the code cleaner.

[chadell]

Looks good to me overall, it's not a blocker but I think if we should leverage pynautobot whenever possible, it makes the code cleaner.

I did it this way to avoid the extra dependency

[dgarros]

I did it this way to avoid the extra dependency

That's a good reminder that we should be consistent here
for the other examples, we didn't add the dependencies to the pyproject.toml, instead we have a requirements.txt file in the example directory

I'm good either way but we should be consistent

@glennmatthews what is your preference ?

[dgarros]

@chadell please can you remove the changes from the pyproject.toml and add a requirements.txt file in your example directory to align with the other examples

[chadell]

@chadell please can you remove the changes from the pyproject.toml and add a requirements.txt file in your example directory to align with the other examples

The requirements.txt file is already present. the changes in pyproject.toml should not be there, will remove.

[dgarros]

Thank you @chadell