Skip to content

Add BASE_INTERFACES for hp_comware & checkpoint - #17

Merged
itdependsnetworks merged 2 commits into
networktocode:developfrom
jifox:additional_mappings
Jun 9, 2021
Merged

Add BASE_INTERFACES for hp_comware & checkpoint#17
itdependsnetworks merged 2 commits into
networktocode:developfrom
jifox:additional_mappings

Conversation

@jifox

@jifoxjifox commented Jun 7, 2021

Copy link
Copy Markdown
Contributor

Added a few interface names

hp_comware:

  • Bridge-Aggregation
  • Ten-GigabitEthernet
  • Vlan-interface

checkpoint_gaia:

  • Sync

Comment threadnetutils/constants.py Outdated
"Serial": "Serial",
"Se": "Serial",
"S": "Serial",
"Sync": "Sy",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be backwards. Should likely be

 "Sy": "Sync",
"Sync": "Sync",

qduk
qduk approved these changes Jun 8, 2021
@itdependsnetworks
itdependsnetworks merged commit 8849420 into networktocode:developJun 9, 2021
@jifox
jifox deleted the additional_mappings branch June 9, 2021 18:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@jifox@itdependsnetworks@qduk@jeffkala@jifoxpa