Feature/platform mapper by bminnix · Pull Request #220 · networktocode/netutils

bminnix · 2023-02-17T21:06:40Z

No description provided.

jeffkala · 2023-03-02T21:34:43Z

@bminnix curious for the use case here. Looks like all this logic just builds urls, but essentially you just need a mapper. Can we just create a NIST mapper instead?

bminnix · 2023-03-03T15:38:43Z

I believe we could.
There currently isn't another use case that needs them broken out into the full breakdown as Juniper is being given. This was an "in case" since I needed to break them down to parse out the different NIST URL possibilities. It was thought that it could be a useful function that could be expanded on when/if other platforms needed it.
In the case of Juniper, the pseudo case that I thought of would be something like, if you needed to look for/take action against a maintenance, special, frs, or other type/stage of release, this would help it to be identified. Or if you were looking for a specific build, it could be found. There were no use cases that stand out.

jeffkala · 2023-03-08T17:41:30Z

Syncing with @bminnix on this ask offline

qduk · 2023-04-27T19:13:20Z

@bminnix Have you had a chance to review the feedback?

bminnix · 2023-05-01T14:19:56Z

I have some chat history with @jeffkala that I need to work on, I just have not had time to make the changes. Will try harder to make time.

jeffkala · 2023-08-08T21:38:54Z

Can we re-evaluate this block? This is alot of conditionals, can we simplify anyway?

So, this is actually the re-evaluated block 😂 , it was much larger and very nested.
Juniper has a pretty complex naming system and is why it's the only OS that we are focusing on parsing right now. Here is a video that kind of goes through the explanation of all the different parts of the version and why there are so many conditionals.
https://www.youtube.com/watch?v=UHW5kiJ9wOg
If you have some suggestions on how we could further improve this block, it would be very welcomed!!

qduk · 2023-08-14T16:22:54Z

@bminnix Can you move the code in os_version_parser.py to os_version.py? I believe that file wasn't there when this PR was initially opened.

jeffkala · 2023-08-22T21:27:09Z

Seems like something weird happened with commit history here? Seems like more changes are in this commit then I would anticipate. Was a rebase done or a merge that might have conflicted?

bminnix · 2023-08-22T21:42:08Z

There were conflicts when I checked the PR, so I rebased, resolved conflicts, and pushed.

EDIT: Not sure what was wrong. Re-rebased and it all seems good now.

…their bits

… arguments instead of a dict

Adding property decorators

qduk · 2023-12-07T20:27:39Z

@bminnix If you get the chance, can you take a look at Ken's comments?

bminnix · 2024-01-31T01:01:40Z

@itdependsnetworks I've worked to resolve the conversations. Please let me know if anything else is needed.

qduk · 2024-02-15T15:59:41Z

This looks good to me. I would think we want to include nist.py in documentation as well. Let me touch base with Jeff and Ken and I'll update this comment

qduk

Thanks for the docs update!

This reverts commit e835dc3.

* Creating a Platform Mapping utility for breaking down platforms into their bits * Updated the create_platform_object function parameters for positional arguments instead of a dict * Did not fix an Example of changed code. * Moving the junos_version_parser to its own function Adding property decorators * Refactor platform mapper. * Fix juniper nist urls fun * Fix juniper nist urls fun * Move nist and version parsers to separate files. Refactor. * Fix bugs. Update tests. * Redo object factory using base class. Rename factory fun. * Address linting issues. * Fix bug with get_nist_urls fun assignment. Rename object factory. * Changing file name back to os_version.py per request from Adam. * Creating a Platform Mapping utility for breaking down platforms into their bits * Updated the create_platform_object function parameters for positional arguments instead of a dict * Did not fix an Example of changed code. * Moving the junos_version_parser to its own function Adding property decorators * Refactor platform mapper. * Fix juniper nist urls fun * Fix juniper nist urls fun * Move nist and version parsers to separate files. Refactor. * Fix bugs. Update tests. * Redo object factory using base class. Rename factory fun. * Address linting issues. * Fix bug with get_nist_urls fun assignment. Rename object factory. * Changing file name back to os_version.py per request from Adam. * Fixing the import for os_version; Added Exception to the raise * Adding an ignore for mypy; This was discussed with Jeff Kala before implementing. * Corrected typo per review * Fixing bugs * Update netutils/platform_mapper.py Co-authored-by: Ken Celenza <ken@celenza.org> * Making changes requested by Ken. Still 5 sections to go. * Removing gets from fstrings * Committing more of Ken's suggestions; escape_list * Making changes to the isspecial evaluation per Ken's suggestion. * Small change to format for Black's happiness * Getting latest lock file to avoid conflicts * Had pylint errors * Had pylint errors * Had black errors after fixing pylint errors * Had black errors after fixing pylint errors * After fixing black errors, more pylint errors. * Black found an extra space. * Updating nist.py to shorten line length; fixing pytest results. * Adding a doc for nist.py * Updating the mkdocs.yml for NIST --------- Co-authored-by: Brandon Minnix <bminnix@Brandons-MacBook-Pro.local> Co-authored-by: Brandon Minnix <brandon.minnix@networktocode.com> Co-authored-by: Przemek Rogala <progala@progala.net> Co-authored-by: Ken Celenza <ken@celenza.org> Co-authored-by: Brandon Minnix <bminnix@Brandons-MacBook-Pro-2.local>

This reverts commit 0228fc5.

bminnix requested review from abates, itdependsnetworks, jeffkala and qduk as code owners February 17, 2023 21:06

bminnix force-pushed the feature/platform_mapper branch 2 times, most recently from 98ea5bf to 6c828a0Compare February 17, 2023 23:50

jeffkala reviewed Mar 3, 2023
View reviewed changes

bminnix mentioned this pull request May 8, 2023
NIST CVE SYNC JOB CREATED nautobot/nautobot-app-device-lifecycle-mgmt#91
Closed

jeffkala reviewed Aug 8, 2023
View reviewed changes

bminnix requested a review from jeffkala August 22, 2023 20:02

bminnix force-pushed the feature/platform_mapper branch from 21c4306 to a18b1ffCompare August 25, 2023 16:43

Brandon Minnixand others added 11 commits August 25, 2023 18:21

Creating a Platform Mapping utility for breaking down platforms into …
8aa04c0
…their bits

Updated the create_platform_object function parameters for positional…
f7da800
… arguments instead of a dict

Did not fix an Example of changed code.
5432226

Moving the junos_version_parser to its own function
7b4ef3c
Adding property decorators

Refactor platform mapper.
62126b4

Fix juniper nist urls fun
3a70405

Fix juniper nist urls fun
3f9c902

Move nist and version parsers to separate files. Refactor.
7f35436

Fix bugs. Update tests.
56b7caf

Redo object factory using base class. Rename factory fun.
c8d9f2f

Address linting issues.
0016d11