Feature/platform mapper - #489

Merged

itdependsnetworks merged 86 commits into

networktocode:developfrom

bminnix:feature/platform_mapper

May 15, 2024

bminnix commented Mar 19, 2024•
edited
Loading

Contributor

Updating netutils for support of the nautobot-app-device-lifecycle-mgmt NIST URL creation for API 2.0

Updating the nist utility to only support certain OS PLatforms:
Cisco IOS
Cisco IOS XR
Cisco IOS XE
Cisco NXOS
Juniper Junos
Arista EOS

bminnix requested review from abates, itdependsnetworks, jeffkala and qduk as code owners

March 19, 2024 14:35

itdependsnetworks reviewed

View reviewed changes

docs/dev/code_reference/nist.md Outdated

itdependsnetworks reviewed

View reviewed changes

docs/dev/code_reference/nist.md Outdated

itdependsnetworks reviewed

View reviewed changes

netutils/lib_mapper.py Outdated

itdependsnetworks reviewed

View reviewed changes

netutils/lib_mapper.py Outdated

itdependsnetworks reviewed

View reviewed changes

mkdocs.yml Outdated

itdependsnetworks reviewed

View reviewed changes

docs/dev/code_reference/nist.md Outdated

itdependsnetworks reviewed

View reviewed changes

netutils/os_version.py Outdated

bminnix force-pushed the feature/platform_mapper branch from ab63cd5 to b8925a1Compare

March 28, 2024 22:06

itdependsnetworks reviewed

View reviewed changes

netutils/os_version.py Outdated

itdependsnetworks reviewed

View reviewed changes

netutils/os_version.py Outdated

itdependsnetworks commented Apr 25, 2024

Contributor

@bminnix as we spoke about we will:

Create an os_version_parser (or similar) and it will always provide major/minor/patch
If you provide an OS, it will attempt to parse it futher with an OS specfic parser, like "if operating_system == "junos": return _junos_os_version_parser()
keep all of the nist in itself

bminnix commented Apr 26, 2024

ContributorAuthor

Yes sir! Getting this dev into my regular schedule.

Brandon Minnixand others added 14 commits

April 26, 2024 15:20

Creating a Platform Mapping utility for breaking down platforms into …

82c173f

…their bits

Updated the create_platform_object function parameters for positional…

ce7b74d

… arguments instead of a dict

Did not fix an Example of changed code.

1c1b23b

Moving the junos_version_parser to its own function

5658894

Adding property decorators

Refactor platform mapper.

20eb7e8

Fix juniper nist urls fun

d5ae58d

Fix juniper nist urls fun

39dd85d

Move nist and version parsers to separate files. Refactor.

b52177e

Fix bugs. Update tests.

1d37620

Redo object factory using base class. Rename factory fun.

cb17648

Address linting issues.

1b4083a

Fix bug with get_nist_urls fun assignment. Rename object factory.

fb63518

Changing file name back to os_version.py per request from Adam.

c07bbd3

Creating a Platform Mapping utility for breaking down platforms into …

6a84868

…their bits

Brandon Minnix added 6 commits

April 26, 2024 15:23

Adding mapping for asa software.

defe375

Updating os_version to include a convenience function for os version …

e089fc7

…parsing

Updating the os_version module to include a jinja friendly function f…

a20dbdb

…or os_version_parsing. Updated docs.

Somehow, really old code was added back into the lib_mapper.py in my …

02692a9

…branch.

Updating some functions with new names based on Ken's recommendation …

8d9b534

…of using metadata.

Making changes suggested during PR and discussion with Ken

074d1f6

bminnix force-pushed the feature/platform_mapper branch from b8925a1 to 074d1f6Compare

April 26, 2024 19:24

Brandon Minnix added 2 commits

April 29, 2024 10:28

Making changes to documentation and functions.

5ff9434

Finishing changes and passing tests.

5557274

bminnix commented Apr 29, 2024

ContributorAuthor

@bminnix as we spoke about we will:
Create an os_version_parser (or similar) and it will always provide major/minor/patch
If you provide an OS, it will attempt to parse it futher with an OS specfic parser, like "if operating_system == "junos": return _junos_os_version_parser()
keep all of the nist in itself

I believe all of the above is now factored in and ready for review.

bminnix commented Apr 30, 2024

ContributorAuthor

@bminnix as we spoke about we will:
Create an os_version_parser (or similar) and it will always provide major/minor/patch
If you provide an OS, it will attempt to parse it futher with an OS specfic parser, like "if operating_system == "junos": return _junos_os_version_parser()
keep all of the nist in itself
I believe all of the above is now factored in and ready for review.

@itdependsnetworks Forgot to @ you

itdependsnetworks reviewed

View reviewed changes

docs/dev/code_reference/platform_mapper.md Outdated

itdependsnetworks reviewed

View reviewed changes

docs/user/lib_use_cases.md Outdated

itdependsnetworks reviewed

View reviewed changes

netutils/nist.py Outdated

itdependsnetworks reviewed

View reviewed changes

netutils/os_version.py Outdated

itdependsnetworks reviewed

View reviewed changes

netutils/os_version.py Outdated

bminnix added 4 commits

May 10, 2024 18:36

Updates after discussion with Ken today. Removing several functions f…

8edbe98

…rom public/utils and providing a single function to get urls. Updated docs and tests

Added Protocol Mapper back to lib_use_cases and removed Platform Mapper

9504704

Updating _default_version_metadata to _basic_version_metadata

d31aae6

Removing reference to 'Platform Mapper' from the mkdocs.yml

054a5be

itdependsnetworks reviewed

View reviewed changes

tests/unit/test_utils.py Outdated

itdependsnetworks reviewed

View reviewed changes

docs/user/lib_use_cases_os_version.md Outdated

itdependsnetworks commented May 12, 2024

Contributor

light cleanup... then i think we are good to merge!!

bminnix added 3 commits

May 12, 2024 00:13

A couple of cleanup items missed/resolved.

abffe5d

Updating the nist.py to include the main get_nist_urls() using networ…

922953f

…k_driver.

Forgot to update documentation to use network_driver instead of vendo…

670297e

…r, os_platform

itdependsnetworks approved these changes

View reviewed changes

jeffkala approved these changes

View reviewed changes

itdependsnetworks merged commit 373e5cc into networktocode:develop

michalis1 pushed a commit to michalis1/netutils that referenced this pull request

Feature/platform mapper (networktocode#489)

79e11c6

* Creating a Platform Mapping utility for breaking down platforms into their bits
---------
Co-authored-by: Brandon Minnix <bminnix@Brandons-MacBook-Pro.local>
Co-authored-by: Brandon Minnix <brandon.minnix@networktocode.com>
Co-authored-by: Przemek Rogala <progala@progala.net>
Co-authored-by: Ken Celenza <ken@celenza.org>
Co-authored-by: Brandon Minnix <bminnix@Brandons-MacBook-Pro-2.local>

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment