Rename market symbol filter to market_id - #1
Merged
Merged
Conversation
Sync with python-client: the /market and /market/count endpoints now take market_id instead of symbol. The old filter was removed upstream, so no alias is kept. Also add symbol and marketId to the Article record. The API returns both fields as string arrays; neither was modelled before. Article is only ever JSON-decoded, so appending record components is source-compatible.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs this client with the python-client market update (PRs #24–#26).
Request filter
The
/marketand/market/countendpoints now takemarket_idinstead ofsymbol. The old filter was removed upstream (62c4f80 removed symbol filter from market endpoints), so no back-compat alias is kept — this is a breaking change for anyone passingsymbol.Verification
Full test suite passes. Note the published
openapi.jsonis stale: it still documentssymboland has nomarket_id, so it could not be used to verify this change.Response fields
The API returns both
symbolandmarket_idon market articles, as string arrays. Neither was modelled on the typedArticlebefore; both are now.Articleis only ever JSON-decoded (no direct constructor calls anywhere), so this is source-compatible.