Skip to content

[stable6] feat(FilePicker): Improve pick and navigation logic to match user expectation - #2051

Merged
susnux merged 4 commits into
stable6from
backport/2033/stable6
Oct 22, 2025
Merged

[stable6] feat(FilePicker): Improve pick and navigation logic to match user expectation#2051
susnux merged 4 commits into
stable6from
backport/2033/stable6

Conversation

@backportbot

@backportbotbackportbotBot commented Oct 22, 2025

Copy link
Copy Markdown

Backport of #2033

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
backportbotBot requested review from artonge and susnuxOctober 22, 2025 07:47
@backportbotbackportbotBot added enhancement New feature or request 3. to review file picker javascript Pull requests that update javascript code labels Oct 22, 2025
@artonge
artongeforce-pushed the backport/2033/stable6 branch 3 times, most recently from c43d6c2 to 16a054bCompareOctober 22, 2025 08:26
@artonge
artonge marked this pull request as ready for review October 22, 2025 08:26
Signed-off-by: Louis Chmn <louis@chmn.me>
This will inhibit selection of nodes
Signed-off-by: Louis Chmn <louis@chmn.me>
Signed-off-by: Louis Chmn <louis@chmn.me>
Signed-off-by: Louis Chmn <louis@chmn.me>
@susnux
susnuxforce-pushed the backport/2033/stable6 branch from 16a054b to 34067acCompareOctober 22, 2025 10:32
@susnux

Copy link
Copy Markdown
Contributor

(rebased for CI)

@codecov

codecovBot commented Oct 22, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.96%. Comparing base (6ee3bd5) to head (34067ac).
⚠️ Report is 5 commits behind head on stable6.

Files with missing linesPatch %Lines
lib/filepicker-builder.ts0.00%10 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## stable6 #2051 +/- ##
===========================================
- Coverage 43.53% 42.96% -0.57% 
===========================================
Files 22 22 Lines 758 768 +10 Branches 92 92 ===========================================
Hits 330 330 - Misses 427 437 +10 
Partials 1 1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@susnux
susnux merged commit ae340f3 into stable6Oct 22, 2025
8 of 10 checks passed
@susnux
susnux deleted the backport/2033/stable6 branch October 22, 2025 10:35
@susnuxsusnux mentioned this pull request Oct 22, 2025
artonge added a commit that referenced this pull request Oct 22, 2025
Was wrongly changed by #2051
Signed-off-by: Louis Chmn <louis@chmn.me>
artonge added a commit that referenced this pull request Oct 22, 2025
Was wrongly changed by #2051
Signed-off-by: Louis Chmn <louis@chmn.me>
artonge added a commit that referenced this pull request Oct 22, 2025
Was wrongly changed by #2051
Signed-off-by: Louis Chmn <louis@chmn.me>
artonge added a commit that referenced this pull request Oct 22, 2025
Was wrongly changed by #2051
Signed-off-by: Louis Chmn <louis@chmn.me>
artonge added a commit that referenced this pull request Oct 22, 2025
Was wrongly changed by #2051
Signed-off-by: Louis Chmn <louis@chmn.me>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewenhancementNew feature or requestfile pickerjavascriptPull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@susnux@artonge