Skip to content

feat: Open previews in Viewer - #1398

Merged
susnux merged 2 commits into
masterfrom
feat/open-in-viewer
Nov 9, 2023
Merged

feat: Open previews in Viewer#1398
susnux merged 2 commits into
masterfrom
feat/open-in-viewer

Conversation

@susnux

@susnuxsusnux commented Nov 8, 2023

Copy link
Copy Markdown
Contributor

To allow previews / files to be opened in the viewer we need to pass the full file path in the previews. So a small API change (non breaking).

It looks like this now:

vokoscreenNG-2023-11-09_00-52-15.mp4

@susnuxsusnux added this to the Nextcloud 28 milestone Nov 8, 2023
@susnux
susnuxforce-pushed the feat/open-in-viewer branch 3 times, most recently from 80f8434 to 3dcb3d4CompareNovember 9, 2023 00:36
@blizzzblizzz mentioned this pull request Nov 9, 2023
Merged
artonge
artonge reviewed Nov 9, 2023
View reviewed changes
Comment threadsrc/components/Activity.vue
artonge
artonge reviewed Nov 9, 2023
View reviewed changes
Comment threadsrc/components/Activity.vue Outdated
Comment threadsrc/components/Activity.vue Outdated
@susnux
feat: Open previews using the viewer
95617d3
Add full file path to previews so the viewer can load it
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnuxforce-pushed the feat/open-in-viewer branch from 3dcb3d4 to 2723a25CompareNovember 9, 2023 14:07
@susnux

susnux commented Nov 9, 2023

Copy link
Copy Markdown
ContributorAuthor

Resolved the comments

@susnux
chore: Compile assets
64b5aac
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnuxforce-pushed the feat/open-in-viewer branch from 2723a25 to 64b5aacCompareNovember 9, 2023 14:46
@susnux
susnux merged commit f5289cc into masterNov 9, 2023
@susnux
susnux deleted the feat/open-in-viewer branch November 9, 2023 16:46
@github-actions

github-actionsBot commented Nov 23, 2023

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

This was referenced Apr 9, 2025
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artongeartongeartonge approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@miaulalalamiaulalalaAwaiting requested review from miaulalala

Assignees

No one assigned

Labels

3. to reviewenhancementfeature: streamfeedback-requested

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

[BITV] Accessibility issues

3 participants

@susnux@artonge@skjnldsv