Uh oh!
There was an error while loading. Please reload this page.
[stable29] forces sidebarPlugins to unmount and mount during an ActivityTab update - #1771
Merged
Conversation
susnux
commented
Sep 5, 2024
Contributor
This resolves #1772 |
susnuxforce-pushed
the
backport/1732/stable29
branch
from
September 5, 2024 17:30
a91965c to
19310d5Comparesusnux
marked this pull request as ready for review
September 5, 2024 17:30
susnux
approved these changes
Sep 5, 2024
susnux
commented
Sep 5, 2024
Contributor
/compile amend/ |
… update sidebarPlugins is initialized as empty array and during next reattached so vue force a remount Signed-off-by: Jan Messer <jan@mtec-studios.ch> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-commandforce-pushed
the
backport/1732/stable29
branch
from
September 5, 2024 18:18
bf3cde9 to
06e51ebCompareActivity | |||||||||||||||||||||||||||||||||||||||||||
| Project | Activity |
| Branch Review | backport/1732/stable29 |
| Run status | |
| Run duration | 05m 11s |
| Commit | |
| Committer | backportbot[bot] |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 Failures | 2 |
 Flaky | 1 |
 Pending | 0 |
 Skipped | 0 |
 Passing | 8 |
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/sidebar.cy.ts • 2 failed tests • Run E2E
| Test | Artifacts | |
|---|---|---|
| Check activity listing in the sidebar > Has favorite activity | Test ReplayScreenshots | |
| Check activity listing in the sidebar > Has rename activity | Test ReplayScreenshots | |
cypress/e2e/sidebar.cy.ts • 1 flaky test • Run E2E
| Test | Artifacts | |
|---|---|---|
| Check activity listing in the sidebar > Has tag activity | Test ReplayScreenshots | |
artonge
approved these changes
Sep 9, 2024
artonge
enabled auto-merge
September 9, 2024 10:15
artonge
disabled auto-merge
September 9, 2024 14:36
artonge
enabled auto-merge
September 9, 2024 14:36
artonge
disabled auto-merge
September 9, 2024 14:36
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.