Uh oh!
There was an error while loading. Please reload this page.
fix(ActivityAppFeed): handle cases for non-scrollable container - #1963
Merged
Conversation
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesyforce-pushed
the
fix/1909/handle-non-scrollable
branch
from
April 3, 2025 15:12
6adca7d to
3f7bb9cCompareAntreesy
commented
Apr 3, 2025
ContributorAuthor
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## master #1963 +/- ##
==========================================
- Coverage 30.89% 30.80% -0.10%
==========================================
Files 43 43 Lines 1615 1620 +5 Branches 110 110 ==========================================
Hits 499 499 - Misses 1090 1095 +5
Partials 26 26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Activity | |||||||||||||||||||||||||||||||||||||
| Project | Activity |
| Branch Review | fix/1909/handle-non-scrollable |
| Run status | |
| Run duration | 03m 39s |
| Commit | |
| Committer | Maksim Sukharev |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 Failures | 2 |
 Flaky | 0 |
 Pending | 0 |
 Skipped | 0 |
 Passing | 8 |
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/sidebar.cy.ts • 2 failed tests • Run E2E
| Test | Artifacts | |
|---|---|---|
| Check activity listing in the sidebar > Has rename activity | Test ReplayScreenshots | |
| Check activity listing in the sidebar > Has comment activity | Test ReplayScreenshots | |
AndyScherzinger
approved these changes
Apr 3, 2025
artonge
approved these changes
Apr 3, 2025
Antreesy
commented
Apr 3, 2025
ContributorAuthor
/backport 3f7bb9c to stable31 |
Antreesy
commented
Apr 3, 2025
ContributorAuthor
/backport 3f7bb9c to stable30 |
Antreesy
commented
Apr 3, 2025
ContributorAuthor
/backport 3f7bb9c to stable29 |
This was referenced Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useInfiniteScroll does not call the callback, if there is nothing to scroll.
Added manual check for it
2025-04-03_17h11_13.mp4