Uh oh!
There was an error while loading. Please reload this page.
fix: Improving logging of invalid parameters for activity subject and… - #1975
Merged
Conversation
Merged
4 tasks
provokateurin
approved these changes
Apr 9, 2025
Activity | |||||||||||||||||||||||||||||||||||||||||||
| Project | Activity |
| Branch Review | ref/52062/improve-parameter-logging |
| Run status | |
| Run duration | 03m 19s |
| Commit | |
| Committer | Joas Schilling |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 Failures | 1 |
 Flaky | 2 |
 Pending | 0 |
 Skipped | 0 |
 Passing | 9 |
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/sidebar.cy.ts • 1 failed test • Run E2E
| Test | Artifacts | |
|---|---|---|
| Check activity listing in the sidebar > Has rename activity | Test ReplayScreenshots | |
cypress/e2e/sidebar.cy.ts • 2 flaky tests • Run E2E
| Test | Artifacts | |
|---|---|---|
| Check activity listing in the sidebar > Has share activity | Test ReplayScreenshots | |
| Check activity listing in the sidebar > Has comment activity | Test ReplayScreenshots | |
… message Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessenforce-pushed
the
ref/52062/improve-parameter-logging
branch
from
April 9, 2025 07:29
0da618b to
8ad3856Comparenickvergessen
commented
Apr 9, 2025
MemberAuthor
/backport to stable31 |
nickvergessen
commented
Apr 9, 2025
MemberAuthor
/backport to stable30 |
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
commented
Apr 11, 2025
MemberAuthor
/backport to stable31 |
nickvergessen
commented
Apr 11, 2025
MemberAuthor
/backport to stable30 |
miaulalala
approved these changes
Apr 14, 2025
This was referenced Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… message