Skip to content

Fix multiple cypress issues - #1983

Merged
susnux merged 6 commits into
masterfrom
fix/noid/cypress-force-activity-tab
Apr 18, 2025
Merged

Fix multiple cypress issues#1983
susnux merged 6 commits into
masterfrom
fix/noid/cypress-force-activity-tab

Conversation

@SystemKeeper

@SystemKeeperSystemKeeper commented Apr 18, 2025

Copy link
Copy Markdown
Contributor

Fixes:

  • Force click on activity tab, as it could be under a toast
  • Wait for preview to be generated, to ensure the file is not locked by preview generation
  • Reload the page after adding a comment (as is done for tags)
  • Don't stop containers on CI to extract nextcloud logs
  • Record video when job runs in debug mode
  • Reduce containers from 3 -> 2 as we only have 2 suites anyway (IMO it can also be just 1...)

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@codecov

codecovBot commented Apr 18, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.80%. Comparing base (dde1600) to head (a4683fd).
Report is 17 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #1983 +/- ##
=======================================
Coverage 30.80% 30.80% =======================================
Files 43 43 Lines 1620 1620 Branches 110 110 =======================================
Hits 499 499 Misses 1095 1095 Partials 26 26 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress

cypressBot commented Apr 18, 2025

Copy link
Copy Markdown

ActivityRun #2513

Run Properties:status check passed Passed #2513git commitd59b9e1a97: fix(cypress): Force click on activity tab
ProjectActivity
Branch Reviewfix/noid/cypress-force-activity-tab
Run statusstatus check passed Passed #2513
Run duration02m 17s
Commitgit commitd59b9e1a97: fix(cypress): Force click on activity tab
CommitterMarcel Müller
View all properties for this run ↗︎

Test results
Tests that failedFailures0
Tests that were flakyFlaky1
Tests that did not run due to a developer annotating a test with .skipPending0
Tests that did not run due to a failure in a mocha hookSkipped0
Tests that passedPassing10
View all changes introduced in this branch ↗︎

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
SystemKeeperforce-pushed the fix/noid/cypress-force-activity-tab branch from d63aaac to 6d0573bCompareApril 18, 2025 16:17
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
SystemKeeperforce-pushed the fix/noid/cypress-force-activity-tab branch from 6096c15 to a4683fdCompareApril 18, 2025 17:05
@SystemKeeperSystemKeeper changed the title fix(cypress): Force click on activity tabFix multiple cypress issuesApr 18, 2025
@SystemKeeper
SystemKeeper marked this pull request as ready for review April 18, 2025 17:12
@susnux
susnux merged commit e9b0328 into masterApr 18, 2025
@susnux
susnux deleted the fix/noid/cypress-force-activity-tab branch April 18, 2025 17:26
@SystemKeeperSystemKeeper mentioned this pull request Apr 18, 2025
@artonge

Copy link
Copy Markdown
Collaborator

/backport to stable31

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@SystemKeeper@artonge@susnux