Skip to content

perf: pass the node of shares around instead getting the path from id each time - #2098

Merged
icewind1991 merged 3 commits into
masterfrom
share-hook-path
Aug 13, 2025
Merged

perf: pass the node of shares around instead getting the path from id each time#2098
icewind1991 merged 3 commits into
masterfrom
share-hook-path

Conversation

@icewind1991

@icewind1991icewind1991 commented Aug 11, 2025•
edited
Loading

Copy link
Copy Markdown
Member

No need for a expensive by-id searches if the share event already has the node

@cypress

cypressBot commented Aug 11, 2025•
edited
Loading

Copy link
Copy Markdown

ActivityRun #2770

Run Properties:status check passed Passed #2770 • git commit05ec2385a8: perf: pass the node of shares source instead of re-fetching it's path
ProjectActivity
Branch Reviewshare-hook-path
Run statusstatus check passed Passed #2770
Run duration02m 04s
Commitgit commit05ec2385a8: perf: pass the node of shares source instead of re-fetching it's path
CommitterRobin Appelman
View all properties for this run ↗︎
Test results
Tests that failedFailures0
Tests that were flakyFlaky0
Tests that did not run due to a developer annotating a test with .skipPending0
Tests that did not run due to a failure in a mocha hookSkipped0
Tests that passedPassing10
View all changes introduced in this branch ↗︎

@icewind1991

icewind1991 commented Aug 12, 2025

Copy link
Copy Markdown
MemberAuthor

The entire FileHooks is a mess performance wise...

@icewind1991
icewind1991 marked this pull request as draft August 13, 2025 09:16
@icewind1991icewind1991 changed the title perf: pass the path of link share source instead of re-calculating itperf: pass the node of shares source instead of re-fetching it's pathAug 13, 2025
@icewind1991
perf: pass share node instead of fileid in sharing file hooks
f1d4b52
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
test: adjust tests to hook changes
7afaac8
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
chore: update psalm stubs and baseline
84bf1d8
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 changed the title perf: pass the node of shares source instead of re-fetching it's pathperf: pass the node of shares around instead getting the path from id each timeAug 13, 2025
@icewind1991
icewind1991 marked this pull request as ready for review August 13, 2025 13:39
@icewind1991icewind1991 added this to the Nextcloud 32 milestone Aug 13, 2025
@icewind1991
icewind1991 merged commit db380fa into masterAug 13, 2025
59 checks passed
@icewind1991
icewind1991 deleted the share-hook-path branch August 13, 2025 14:32
@icewind1991

icewind1991 commented Aug 13, 2025

Copy link
Copy Markdown
MemberAuthor

/backport to stable31

@icewind1991

icewind1991 commented Aug 13, 2025

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

@backportbotbackportbotBot mentioned this pull request Aug 13, 2025
Merged
2 tasks
@backportbotbackportbotBot mentioned this pull request Aug 13, 2025
Closed
2 tasks
@icewind1991icewind1991 mentioned this pull request Aug 14, 2025
Merged
@skjnldsvskjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsvskjnldsv removed this from the Nextcloud 32 milestone Sep 28, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@st3inyst3inyst3iny approved these changes
@CarlSchwanCarlSchwanCarlSchwan approved these changes
@susnuxsusnuxAwaiting requested review from susnux

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

4 participants

@icewind1991@st3iny@CarlSchwan@skjnldsv