Uh oh!
There was an error while loading. Please reload this page.
[stable33] fix: Fix handling of deleting share from self - #2385
Merged
Conversation
If a share is deleted from self and it is not a group share it was handled as a user share. However, other types of shares can be deleted from self (for example, circle or room shares), so user shares need to be explicitly checked. Note that as those other share types are not explicitly handled no entry is added to the activity for them, but that was already the case before (this change just prevents an exception to be thrown). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
approved these changes
Feb 19, 2026
miaulalala
approved these changes
Feb 19, 2026
miaulalala
enabled auto-merge
February 19, 2026 14:08
Activity | ||||||||||||||||||||||||||||
| Project | Activity |
| Branch Review | backport/2319/stable33 |
| Run status | |
| Run duration | 02m 39s |
| Commit | |
| Committer | backportbot[bot] |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 Failures | 0 |
 Flaky | 0 |
 Pending | 1 |
 Skipped | 0 |
 Passing | 9 |
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #2319