Skip to content

Add Calendar event proper formatting - #420

Merged
nickvergessen merged 1 commit into
masterfrom
add-calendar-event-support
Apr 21, 2020
Merged

Add Calendar event proper formatting#420
nickvergessen merged 1 commit into
masterfrom
add-calendar-event-support

Conversation

@tcitworld

@tcitworldtcitworld commented Jan 21, 2020

Copy link
Copy Markdown
Member

See nextcloud/server#19039 first

Without this, links to calendar events are not properly formatted (the last last item has got a link on "test").
I don't know much the Activity app so there's probably an easier way to do this.

BeforeAfter
Screenshot_2020-01-21 Activity - NextcloudScreenshot_2020-01-21 Activity - Nextcloud- 2

@nickvergessen

Copy link
Copy Markdown
Member

I can't seem to find any difference?

@tcitworld

tcitworld commented Jan 22, 2020

Copy link
Copy Markdown
MemberAuthor

See the last line in my screenshots.

The default behavior when there's a link doesn't put a <strong> tag on the element.

@rullzer

Copy link
Copy Markdown
Member

@nickvergessen yay or nay?

@nickvergessen

Copy link
Copy Markdown
Member

sure

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld
tcitworldforce-pushed the add-calendar-event-support branch from 4edfa3b to d7e927bCompareApril 17, 2020 08:23
@tcitworld

Copy link
Copy Markdown
MemberAuthor

Rebased

@nickvergessen
nickvergessen merged commit 1557c5b into masterApr 21, 2020
@delete-merged-branch
delete-merged-branchBot deleted the add-calendar-event-support branch April 21, 2020 09:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tcitworld@nickvergessen@rullzer