Skip to content

Harden code to not explode if a storage has no owner - #436

Closed
rullzer wants to merge 1 commit into
masterfrom
fix/no_owner
Closed

Harden code to not explode if a storage has no owner#436
rullzer wants to merge 1 commit into
masterfrom
fix/no_owner

Conversation

@rullzer

Copy link
Copy Markdown
Member

Related to nextcloud/server#19978

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

Related to nextcloud/server#19978
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@nickvergessen

Copy link
Copy Markdown
Member

I'd like to not do this and instead fix storages to always return an owner. and if they dont have one, the mountpoint owner should be returned in my opinion:
nextcloud/groupfolders#797

@juliusknorrjuliusknorr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still do this as then we would not break existing storage implementations that do not provide an owner yet.

@nickvergessen

Copy link
Copy Markdown
Member

Conflicting files
lib/FilesHooks.php

🙊

I would still do this as then we would not break existing storage implementations that do not provide an owner yet.

Well, yes and no. Not breaking is good. On the other hand this is the only point where we know that our storages still return wrong info

@rullzerrullzer mentioned this pull request Apr 4, 2020
80 tasks
@rullzer

Copy link
Copy Markdown
MemberAuthor

so... merge or close?

@juliusknorr

Copy link
Copy Markdown
Member

Well, yes and no. Not breaking is good. On the other hand this is the only point where we know that our storages still return wrong info.

Fine by me then, we still have some time to see during 19 beta/rc if that breaks somewhere and fix it then.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@nickvergessen@juliusknorr