Uh oh!
There was an error while loading. Please reload this page.
[stable18] Use the usermountcache to get all users who have access to a file - #457
Merged
Conversation
backportbot-nextcloudBot
requested review from
icewind1991, nickvergessen and rullzerMay 5, 2020 13:57
nickvergessen
commented
May 5, 2020
Member
Needs real life checking if the used apis are available on 18 |
1 task
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
icewind1991force-pushed
the
backport/190/stable18
branch
from
May 25, 2020 13:54
f44c1ed to
2a3a63fCompareicewind1991
commented
May 25, 2020
Member
rebased and tested, all works as expected |
icewind1991
approved these changes
May 25, 2020
| $this->config->expects($this->once()) | ||
| ->method('getSystemValueBool') | ||
| ->with('activity_use_cached_mountpoints', false) | ||
| ->willReturn($mountCacheUsed); |
There was a problem hiding this comment.
Undefined variable: mountCacheUsed
You added it in the doc block, but not the arguments list
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
approved these changes
May 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #190