Skip to content

Update Toolchain/Android-Target to v24 - #12

Merged
AndyScherzinger merged 14 commits into
masterfrom
build24
Nov 2, 2016
Merged

Update Toolchain/Android-Target to v24#12
AndyScherzinger merged 14 commits into
masterfrom
build24

Conversation

@AndyScherzinger

@AndyScherzingerAndyScherzinger commented Aug 14, 2016•
edited
Loading

Copy link
Copy Markdown
Member

bump everything to 24 so the app project can then move to v24 to support Android N.

@AndyScherzinger

AndyScherzinger commented Aug 15, 2016

Copy link
Copy Markdown
MemberAuthor

cc: @tobiasKaminsky and @nextcloud/android for review.

@AndyScherzinger
AndyScherzingerforce-pushed the build24 branch 3 times, most recently from 193779c to 3021c14CompareAugust 15, 2016 11:16
@AndyScherzingerAndyScherzinger mentioned this pull request Aug 15, 2016
Merged
@AndyScherzinger

AndyScherzinger commented Aug 16, 2016•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@tobiasKaminsky is it okay for you if I merge this, create a new version 1.0.8 to use in my app branch to work on the general v25 version bump?

@AndyScherzingerAndyScherzinger added this to the NC Android lib 1.0.5 milestone Aug 16, 2016
@AndyScherzingerAndyScherzinger modified the milestones: NC Android lib 1.0.6, NC Android lib 1.0.5Aug 31, 2016
@AndyScherzingerAndyScherzinger modified the milestones: NC Android lib 1.0.7, NC Android lib 1.0.6Aug 31, 2016
@AndyScherzinger
AndyScherzingerforce-pushed the build24 branch 2 times, most recently from 50bee26 to 91b4ec0CompareSeptember 7, 2016 09:45
@tobiasKaminsky

tobiasKaminsky commented Sep 9, 2016

Copy link
Copy Markdown
Member

Let's do in parallel with app 1.4.0.
Maybe there will be already android N support ;)

tobiasKaminsky
tobiasKaminsky reviewed Sep 9, 2016
View reviewed changes
Comment threadtest_client/tests/res/values/strings.xml
<resources>

<string name="app_name">Oc_framework-testTest</string>
<string name="app_name">Nc_framework-testTest</string>

@tobiasKaminskytobiasKaminskySep 9, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch ;)

@tobiasKaminsky

tobiasKaminsky commented Sep 9, 2016

Copy link
Copy Markdown
Member

code wise 👍
We have to test it extensively.

@AndyScherzingerAndyScherzinger modified the milestones: NC Android lib 1.0.8, NC Android lib 1.0.7Sep 26, 2016
tobiasKaminsky
tobiasKaminsky previously requested changes Oct 19, 2016
View reviewed changes
Comment thread.drone.yml
environment:
- ANDROID_TARGET=android-24
- ANDROID_ABI=armeabi-v7a
- LD_LIBRARY_PATH=/usr/lib/x86_64-linux-gnu/:/opt/android-sdk-linux/tools/lib64/gles_mesa/

@tobiasKaminskytobiasKaminskyOct 19, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this whole drone.yml up to date?

@AndyScherzingerAndyScherzingerOct 19, 2016

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to check, but I thought so

@AndyScherzingerAndyScherzingerOct 31, 2016

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this one is fine :)

@AndyScherzingerAndyScherzinger changed the title Update Toolchain/Android-Target to v24Update Toolchain/Android-Target to v25Oct 24, 2016
@AndyScherzingerAndyScherzinger changed the title Update Toolchain/Android-Target to v25Update Toolchain/Android-Target to v24Oct 26, 2016
@AndyScherzinger

AndyScherzinger commented Oct 31, 2016

Copy link
Copy Markdown
MemberAuthor

@tobiasKaminsky anything else to do here in your opinion?

@AndyScherzinger
AndyScherzinger dismissed tobiasKaminsky’s stale reviewNovember 2, 2016 21:58

as discussed, this is no issue

@AndyScherzinger

AndyScherzinger commented Nov 2, 2016

Copy link
Copy Markdown
MemberAuthor

merging... 👍

The thing missing in the build file is

- ant clean
- ant debug
- cd test_client/tests
- ant acceptance-test
- cd ../..

since we do not have a server yet to run integration tests on...

@AndyScherzinger
AndyScherzinger merged commit 3a81bd5 into masterNov 2, 2016
@AndyScherzinger
AndyScherzinger deleted the build24 branch November 2, 2016 22:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminskytobiasKaminskytobiasKaminsky left review comments

Assignees

No one assigned

Labels

4. to release

Projects

None yet

Milestone

NC lib 1.0.8

Development

Successfully merging this pull request may close these issues.

2 participants

@AndyScherzinger@tobiasKaminsky