Skip to content

Allow edit on link share on a file - #281

Merged
tobiasKaminsky merged 1 commit into
masterfrom
editOnLinkShare
Apr 29, 2019
Merged

Allow edit on link share on a file#281
tobiasKaminsky merged 1 commit into
masterfrom
editOnLinkShare

Conversation

@tobiasKaminsky

@tobiasKaminskytobiasKaminsky commented Apr 18, 2019

Copy link
Copy Markdown
Member

Needed by nextcloud/android#3923

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

Lint

TypemasterPR
Warnings00
Errors00

FindBugs (new)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings39
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings17
Dodgy code Warnings84
Total187

FindBugs (master)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings39
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings17
Dodgy code Warnings84
Total187

@codecov

codecovBot commented Apr 18, 2019

Copy link
Copy Markdown

Codecov Report

Merging #281 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #281 +/- ##
==========================================
- Coverage 12.45% 12.43% -0.02% 
==========================================
Files 120 120 Lines 5204 5211 +7 Branches 714 716 +2 ==========================================
Hits 648 648 - Misses 4448 4455 +7 
Partials 108 108
Impacted FilesCoverage Δ
...b/resources/shares/UpdateRemoteShareOperation.java0% <0%> (ø)⬆️

1 similar comment
@codecov

codecovBot commented Apr 18, 2019

Copy link
Copy Markdown

Codecov Report

Merging #281 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #281 +/- ##
==========================================
- Coverage 12.45% 12.43% -0.02% 
==========================================
Files 120 120 Lines 5204 5211 +7 Branches 714 716 +2 ==========================================
Hits 648 648 - Misses 4448 4455 +7 
Partials 108 108
Impacted FilesCoverage Δ
...b/resources/shares/UpdateRemoteShareOperation.java0% <0%> (ø)⬆️

@tobiasKaminsky
tobiasKaminsky merged commit a636084 into masterApr 29, 2019
@tobiasKaminsky
tobiasKaminsky deleted the editOnLinkShare branch April 29, 2019 06:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tobiasKaminsky@nextcloud-android-bot@AndyScherzinger