Skip to content

lgtm: not self assigning 👍 - #4

Merged
AndyScherzinger merged 1 commit into
masterfrom
noSelfApproving
Aug 1, 2016
Merged

lgtm: not self assigning 👍#4
AndyScherzinger merged 1 commit into
masterfrom
noSelfApproving

Conversation

@tobiasKaminsky

@tobiasKaminskytobiasKaminsky commented Jun 23, 2016

Copy link
Copy Markdown
Member

No description provided.

@AndyScherzinger

AndyScherzinger commented Jun 23, 2016

Copy link
Copy Markdown
Member

👍

1 similar comment
@przybylski

przybylski commented Jul 2, 2016

Copy link
Copy Markdown
Member

👍

@MariusBluem

MariusBluem commented Jul 2, 2016

Copy link
Copy Markdown
Member

👎 This will not work. Neither as it is was done here nor with the version I have tried in nextcloud/server 😢 ...we dont know why and how to fix it currently.

@tobiasKaminsky

tobiasKaminsky commented Jul 3, 2016

Copy link
Copy Markdown
MemberAuthor

@Mar1u5 for us it is working except that it does not recognize sometimes the second thumps up.
What is not working for you?

@MariusBluem

MariusBluem commented Jul 3, 2016

Copy link
Copy Markdown
Member

...the self assigning part is not working @ nextcloud/server. We have tried it several times, but it is still possible 😕 nextcloud/server#238

@AndyScherzinger

AndyScherzinger commented Jul 3, 2016•
edited
Loading

Copy link
Copy Markdown
Member

@Mar1u5 we experienced several hiccups like @tobiasKaminsky mentioned, sometimes +1s aren't detected, sometimes self approval still works. My guess is that LGTM doesn't work consistently but it is still better than not having the LGTM support at all :)

@AndyScherzinger

AndyScherzinger commented Jul 3, 2016•
edited
Loading

Copy link
Copy Markdown
Member

Yay, again the LGTM has hiccups...

@AndyScherzingerAndyScherzinger added this to the Nextcloud Android library 1.0.2 milestone Aug 1, 2016
@AndyScherzinger
AndyScherzinger merged commit e6068f8 into masterAug 1, 2016
@AndyScherzinger
AndyScherzinger deleted the noSelfApproving branch August 1, 2016 12:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

4. to releaseenhancement

Projects

None yet

Milestone

NC lib 1.0.2

Development

Successfully merging this pull request may close these issues.

4 participants

@tobiasKaminsky@AndyScherzinger@przybylski@MariusBluem