Uh oh!
There was an error while loading. Please reload this page.
Avatar Etags - #1658
Merged
Merged
Conversation
tobiasKaminskyforce-pushed
the
avatarETags
branch
from
October 26, 2017 12:56
8d9becf to
3ba3f9bComparetobiasKaminsky
commented
Dec 7, 2017
MemberAuthor
Once nextcloud/server#6876 is merged the problem should be solved as we then always have a bitmap. |
rullzer
commented
Dec 20, 2017
Member
nextcloud/server#6876 is merged :) |
tobiasKaminskyforce-pushed
the
avatarETags
branch
from
December 21, 2017 12:26
213ce41 to
35ac7ebCompareMemberAuthor
nextcloud/server#6876 is independent from this PR as it is NC13 only. Annotated via custom annotation. The idea is that we can use this for tracking code parts which we can later remove. In this case, if min supported version is 13, we can safely delete this code. |
tobiasKaminskyforce-pushed
the
avatarETags
branch
from
January 9, 2018 07:04
dae8b5d to
82d2de1Comparemario
commented
Jan 11, 2018
Contributor
Is this ready for review @tobiasKaminsky ? |
tobiasKaminsky
commented
Jan 11, 2018
MemberAuthor
Yes. Do you want to have it in 2.1? |
mario
commented
Jan 11, 2018
via email
Contributor
Yes …On Thu, 11 Jan 2018 at 11:47, Tobias Kaminsky ***@***.***> wrote:
Yes. Do you want to have it in 2.1?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1658 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAWskfR9Hkunx5DpAfSHFiE0RCRhqWTks5tJea6gaJpZM4P2iwS>
.
|
tobiasKaminskyforce-pushed
the
avatarETags
branch
from
January 11, 2018 10:51
82d2de1 to
07b74b5ComparetobiasKaminsky
commented
Jan 11, 2018
MemberAuthor
Then rebased and ready for review & test. |
tobiasKaminskyforce-pushed
the
avatarETags
branch
3 times, most recently
from
January 15, 2018 07:40
d346f9d to
614d78bCompareadded one more annotation Signed-off-by: tobiaskaminsky <tobias@kaminsky.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves#1566
This caches the etag of an avatar and sends the etag to server and gets
Edit: not query the server too often we could also implement a 15min timeout, or whatever time.