Skip to content

Avatar Etags - #1658

Merged
tobiasKaminsky merged 5 commits into
masterfrom
avatarETags
Jan 15, 2018
Merged

Avatar Etags#1658
tobiasKaminsky merged 5 commits into
masterfrom
avatarETags

Conversation

@tobiasKaminsky

@tobiasKaminskytobiasKaminsky commented Oct 12, 2017

Copy link
Copy Markdown
Member

Resolves#1566

This caches the etag of an avatar and sends the etag to server and gets

  • a new avatar if etag changed -> use new one
  • a 304 response, meaning nothing changed -> show old avatar

Edit: not query the server too often we could also implement a 15min timeout, or whatever time.

@tobiasKaminsky

Copy link
Copy Markdown
MemberAuthor

Once nextcloud/server#6876 is merged the problem should be solved as we then always have a bitmap.

@rullzer

Copy link
Copy Markdown
Member

nextcloud/server#6876 is merged :)

@tobiasKaminsky

tobiasKaminsky commented Dec 21, 2017

Copy link
Copy Markdown
MemberAuthor

nextcloud/server#6876 is independent from this PR as it is NC13 only.
Once NC13 is our oldest supported release we can remove

publicstaticTextDrawablecreateAvatar(StringaccountName, floatradiusInDp) throws

Annotated via custom annotation. The idea is that we can use this for tracking code parts which we can later remove. In this case, if min supported version is 13, we can safely delete this code.

@mario

Copy link
Copy Markdown
Contributor

Is this ready for review @tobiasKaminsky ?

@tobiasKaminsky

Copy link
Copy Markdown
MemberAuthor

Yes. Do you want to have it in 2.1?

@mario

mario commented Jan 11, 2018 via email

Copy link
Copy Markdown
Contributor

@tobiasKaminsky

Copy link
Copy Markdown
MemberAuthor

Then rebased and ready for review & test.

@tobiasKaminskytobiasKaminsky added this to the Nextcloud App 2.1.0 milestone Jan 11, 2018
@tobiasKaminsky
tobiasKaminskyforce-pushed the avatarETags branch 3 times, most recently from d346f9d to 614d78bCompareJanuary 15, 2018 07:40
@tobiasKaminsky
tobiasKaminsky merged commit 8d63ef5 into masterJan 15, 2018
@tobiasKaminsky
tobiasKaminsky deleted the avatarETags branch January 15, 2018 08:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tobiasKaminsky@rullzer@mario@AndyScherzinger