Uh oh!
There was an error while loading. Please reload this page.
Show infos on untrusted domain if available - #2030
Merged
Merged
Conversation
Signed-off-by: tobiaskaminsky <tobias@kaminsky.me>
AndyScherzinger
commented
Jan 23, 2018
Member
I am fine either way too (not valuing feature freezes that much to be honest) while the server schedule says Nc14. So it won't show anyways in the near future 😆 which would point to 3.1 |
tobiasKaminsky
commented
Jan 23, 2018
MemberAuthor
The first PR is always against master, and then, if decided, it will backported with two new PRs ;-) |
Member
Member
@tobiasKaminsky btw. doesn't compile you seem to have missed to push some changes :) |
mario
commented
Jan 23, 2018
Contributor
FIx the build and can go in 3.0. |
tobiasKaminsky
commented
Jan 23, 2018
MemberAuthor
The build is failing as the library PR as there is no new library release. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs Server: nextcloud/server#7991
If the server pr is not available, it will fall back to "unknown error" as before.
@mario@AndyScherzinger do we want to add this in 3.0 (I know it is feature freeze) or do we want to wait for 3.1? Both is fine for me.
Signed-off-by: tobiaskaminsky tobias@kaminsky.me