Export code style

[tobiasKaminsky]

With this AndroidStudio should use the same code formatting for everyone.
Ref: #3320 (comment)

@AndyScherzinger can you test if this does the following:

package com.owncloud.android;
import lombok.Getter;
import lombok.Setter;
public class CodeFormatting {
@Getter @Setter private String test; // this has to be done manually
private void loop() {
for(int i=0;i<10;i++)System.currentTimeMillis();
boolean b;
if(System.currentTimeMillis()>10)b=true;
while(System.currentTimeMillis()>10)System.currentTimeMillis();
}
}

should change after Alt+Shift+L (Reformat Code) to

package com.owncloud.android;
import lombok.Getter;
import lombok.Setter;
public class CodeFormatting {
@Getter @Setter private String test; // this has to be done manually, but it keeps the way
private void loop() {
for (int i = 0; i < 10; i++) {
System.currentTimeMillis();
}
boolean b;
if (System.currentTimeMillis() > 10) {
b = true;
}
while (System.currentTimeMillis() > 10) {
System.currentTimeMillis();
}
}
}

• correct new lines
• braces around one liner if/for/while

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

[nextcloud-android-bot]

Lint

Type	master	PR
Warnings	85	85
Errors

FindBugs (new)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	162
Internationalization Warnings	15
Malicious code vulnerability Warnings	10
Multithreaded correctness Warnings	9
Performance Warnings	120
Security Warnings	204
Dodgy code Warnings	135
Total	690

FindBugs (master)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	162
Internationalization Warnings	15
Malicious code vulnerability Warnings	10
Multithreaded correctness Warnings	9
Performance Warnings	120
Security Warnings	204
Dodgy code Warnings	135
Total	690

[AndyScherzinger]

I gave it a try while during import AS is simply removing all the formatting config changes introduced in this PR.

[mario]

Should you really be importing though @AndyScherzinger ? Or just opening?

[AndyScherzinger]

Hmmm, well I just opened the project since due to the AS files AS is detecting it as a Android Project right away. So yes, I am just opening it.

[tobiasKaminsky]

This also does not work for me :/
There is a https://www.jetbrains.com/help/idea/settings-tools-settings-repository.html, but this also does not work for me, when I am trying it locally…

[codecov]

Codecov Report

Merging #3325 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #3325 +/- ##
========================================
Coverage 6.16% 6.16% Complexity 1 1 ========================================
Files 317 317 Lines 30516 30516 Branches 4389 4389 ========================================
Hits 1882 1882 + Misses 28349 28348 -1 - Partials 285 286 +1

Impacted Files	Coverage Δ	Complexity Δ
.../third_parties/daveKoeller/AlphanumComparator.java	82.14% <0%> (ø)	0% <0%> (ø)	⬇️

[tobiasKaminsky]

So I gave it a new try

• complete new clone from this repo
• close all projects in AS
• in this screen I used "open an existing Android Studio project"
  
• c&p code sample from first post
• Code -> Reformat Code
• seems to work

[AndyScherzinger]

@tobiasKaminsky let's merge it then :)