Skip to content

OCFileListFragment: Only scroll to top if directory changed - #4058

Merged
tobiasKaminsky merged 2 commits into
masterfrom
fixJumpingFileList
May 23, 2019
Merged

OCFileListFragment: Only scroll to top if directory changed#4058
tobiasKaminsky merged 2 commits into
masterfrom
fixJumpingFileList

Conversation

@Unpublished

@UnpublishedUnpublished commented May 22, 2019•
edited by tobiasKaminsky
Loading

Copy link
Copy Markdown
Contributor

Fixes jumping to top everytime the listview is updated, since 3.6.1.

TODO

  • This needs to be tested with talk app

@Unpublished
OCFileListFragment: Only scroll to top if directory changed
e517451
Signed-off-by: Unpublished <unpublished@gmx.net>
@codecov

codecovBot commented May 22, 2019•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #4058 into master will decrease coverage by 0.97%.
The diff coverage is 66.66%.

@@ Coverage Diff @@## master #4058 +/- ##
============================================
- Coverage 12.71% 11.73% -0.98% 
Complexity 1 1 ============================================
Files 329 329 Lines 30998 31000 +2 Branches 4424 4425 +1 ============================================
- Hits 3940 3637 -303 - Misses 26394 26733 +339 + Partials 664 630 -34
Impacted FilesCoverage ΔComplexity Δ
...ncloud/android/ui/fragment/OCFileListFragment.java19.76% <66.66%> (+0.07%)0 <0> (ø)⬇️
...d/android/operations/GetCapabilitiesOperation.java25% <0%> (-50%)0% <0%> (ø)
...owncloud/android/ui/adapter/DiskLruImageCache.java0% <0%> (-31.17%)0% <0%> (ø)
...cloud/android/datamodel/ArbitraryDataProvider.java41.02% <0%> (-29.49%)0% <0%> (ø)
...loud/android/datamodel/FileDataStorageManager.java13.22% <0%> (-12.26%)0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java22.44% <0%> (-6.68%)0% <0%> (ø)
...cloud/android/operations/common/SyncOperation.java31.25% <0%> (-6.25%)0% <0%> (ø)
...m/owncloud/android/ui/activity/DrawerActivity.java34.33% <0%> (-5.36%)0% <0%> (ø)
...in/java/com/owncloud/android/utils/ThemeUtils.java48.14% <0%> (-4.17%)0% <0%> (ø)
...ava/com/owncloud/android/utils/DrawerMenuUtil.java43.24% <0%> (-2.71%)0% <0%> (ø)
... and 9 more

tobiasKaminsky
tobiasKaminsky requested changes May 23, 2019
View reviewed changes

@tobiasKaminskytobiasKaminsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes

Comment threadsrc/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java Outdated
Comment threadsrc/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java Outdated
@tobiasKaminsky

tobiasKaminsky commented May 23, 2019

Copy link
Copy Markdown
Member

@Unpublished thanks for the finding of this, I did not thought about it 🎉
After your changes, I'll test it with Talk.

@Unpublished
Only compare directories if necessary
8c06097
Signed-off-by: Unpublished <unpublished@gmx.net>
@nextcloud-android-bot

nextcloud-android-bot commented May 23, 2019

Copy link
Copy Markdown
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/9392.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot

nextcloud-android-bot commented May 23, 2019

Copy link
Copy Markdown
Collaborator

Codacy

297

Lint

TypemasterPR
Warnings5858
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings74
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings122
Security Warnings47
Dodgy code Warnings141
Total434

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings74
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings122
Security Warnings47
Dodgy code Warnings141
Total434

@tobiasKaminsky

tobiasKaminsky commented May 23, 2019

Copy link
Copy Markdown
Member

Tested and working 👍

@tobiasKaminsky
tobiasKaminsky merged commit f28007e into masterMay 23, 2019
@tobiasKaminsky

tobiasKaminsky commented May 23, 2019

Copy link
Copy Markdown
Member

Thank you very much @Unpublished 🎉 🎉 🎉

@tobiasKaminsky
tobiasKaminsky deleted the fixJumpingFileList branch May 23, 2019 09:00
@Unpublished

Unpublished commented May 23, 2019

Copy link
Copy Markdown
ContributorAuthor

/backport to stable-3.6

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request May 23, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented May 23, 2019

Copy link
Copy Markdown

backport to stable-3.6 in #4062

@Unpublished

Unpublished commented May 23, 2019

Copy link
Copy Markdown
ContributorAuthor

Oh it works 😄
You're very welcome and I'm happy to contribute :)

tobiasKaminsky added a commit that referenced this pull request May 24, 2019
@tobiasKaminsky
daily dev 20190524
245ea82
3b31841 Merge pull request #3969 from nextcloud/receivePushDelete
6074c93 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
f28007e OCFileListFragment: Only scroll to top if directory changed (#4058)
b061e4d Merge commit '51ee4d88fd0555a945a24b1ab3beba2ffdc79c06'
51ee4d8 handle silent delete/delete-all push notifications do not ignore talk messages (will only be sent if no talk app is installed) exclude generated Parcelable
fb6b11f Use product name on rich document, if available (#3971)
4197d3b use proper qa build lib dependency
8c06097 Only compare directories if necessary
403a3e0 Use product name on rich document, if available use placeholder for string reset to master-snapshot fix analysis warning use new translatable string use var vor qa flavor too
9b0a789 Merge pull request #4040 from nextcloud/ezaquarii/remove-findbugs
d6b4dee Remove legacy FindBugs tasks from build script
53c9c05 daily dev 20190523
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminskytobiasKaminskytobiasKaminsky approved these changes

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 3.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Unpublished@tobiasKaminsky@nextcloud-android-bot@AndyScherzinger