Uh oh!
There was an error while loading. Please reload this page.
Connectivity check: no need to use owncloudClient - #4344
Merged
Conversation
AndyScherzinger
approved these changes
Aug 19, 2019
nextcloud-android-bot
commented
Aug 19, 2019
Collaborator
Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/10437 |
nextcloud-android-bot
commented
Aug 20, 2019
Collaborator
Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/10474 |
tobiasKaminskyforce-pushed
the
plainConnection
branch
from
August 20, 2019 07:53
054c6f5 to
a8350a4ComparetobiasKaminskyforce-pushed
the
plainConnection
branch
from
August 20, 2019 10:07
a8350a4 to
dc7c001CompareSigned-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminskyforce-pushed
the
plainConnection
branch
from
August 20, 2019 14:54
c8bd8f2 to
251bb3aCompare… [skip ci] Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
nextcloud-android-bot
commented
Aug 21, 2019
Collaborator
IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/10542 |
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminskyforce-pushed
the
plainConnection
branch
from
August 21, 2019 05:45
af6989a to
6473e7eComparenextcloud-android-bot
commented
Aug 21, 2019
Collaborator
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10543.apk |
nextcloud-android-bot
commented
Aug 21, 2019
Collaborator
Codacy286Lint
SpotBugs (new)
SpotBugs (master)
|
Codecov Report
@@ Coverage Diff @@## master #4344 +/- ##
============================================
+ Coverage 16.81% 16.82% +0.01%
Complexity 1 1 ============================================
Files 358 358 Lines 31791 31788 -3 Branches 4490 4490 ============================================
+ Hits 5345 5349 +4 + Misses 25547 25541 -6 + Partials 899 898 -1
|
1 similar comment
Codecov Report
@@ Coverage Diff @@## master #4344 +/- ##
============================================
+ Coverage 16.81% 16.82% +0.01%
Complexity 1 1 ============================================
Files 358 358 Lines 31791 31788 -3 Branches 4490 4490 ============================================
+ Hits 5345 5349 +4 + Misses 25547 25541 -6 + Partials 899 898 -1
|
AndyScherzinger
commented
Aug 21, 2019
Member
/backport to stable-3.8 |
backport to stable-3.8 in #4362 |
tobiasKaminsky added a commit
that referenced
this pull request
Aug 22, 2019
903b38c [tx-robot] updated from transifex 7a29f48 Sharees will be in NC17 (#4284) 39cb5d9 sharees will be in NC17 later initialization of storageManager add support for groups catch potential wrong saved sharee date 66a8898 Connectivity check: no need to use owncloudClient (#4344) 6473e7e fix unit tests 0d65c29 [tx-robot] updated from transifex 9da4251 daily dev 20190821
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As both endpoints are accessible without credentials, we do not have to use ownCloudClient, which makes invocation a bit easier.
Signed-off-by: tobiasKaminsky tobias@kaminsky.me