Template Dialog: template needs to be selected

[tobiasKaminsky]

Fix#7991
Fix#5144
Closes#6317

@AndyScherzinger this is not beautiful at all, do you have time to enhance this? 💙

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Testing

Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.

unit tests
instrumented tests
UI tests

• Tests written, or not not needed

[stefan-niedermann]

Do the error snackbars disappear immediately when entering a name or clicking on a template?

[codecov]

Codecov Report

Merging #8005 (ea0578d) into master (6c9a639) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@ Coverage Diff @@## master #8005 +/- ##
============================================
- Coverage 29.09% 29.03% -0.06% 
Complexity 5 5 ============================================
Files 443 443 Lines 34841 34939 +98 Branches 4812 4827 +15 ============================================
+ Hits 10136 10145 +9 - Misses 23213 23300 +87 - Partials 1492 1494 +2 

Impacted Files	Coverage Δ	Complexity Δ
...owncloud/android/ui/activity/PassCodeActivity.java	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...droid/ui/adapter/RichDocumentsTemplateAdapter.java	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...m/owncloud/android/ui/adapter/TemplateAdapter.java	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...log/ChooseRichDocumentsTemplateDialogFragment.java	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...ndroid/ui/dialog/ChooseTemplateDialogFragment.java	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
.../dialog/SyncedFolderPreferencesDialogFragment.java	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...droid/ui/fragment/OCFileListBottomSheetDialog.java	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...ncloud/android/ui/fragment/OCFileListFragment.java	38.01% <0.00%> (ø)	0.00 <0.00> (ø)
...in/java/com/owncloud/android/utils/ThemeUtils.java	50.00% <ø> (+0.15%)	0.00 <0.00> (ø)
...a/com/owncloud/android/utils/FileStorageUtils.java	50.00% <0.00%> (-1.17%)	0.00% <0.00%> (ø%)
... and 8 more

[AndyScherzinger]

@tobiasKaminsky DONE

Note that I added a helper text, this way you could change the dialogs behavior:

• grey-out and disable the create button until both infos have been set

[jancborchardt]

Looks very nice! Just 2 questions:

• Are we getting the template previews from the server? Would look nicer than if it's all the filetype icon :)
• Is it possible to prefill the filename input with e.g. the template name, so then it would be "Meeting notes.md" with the cursor before the dot?

[nextcloud-android-bot]

White-Dark-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/8005-Screenshot-White-Dark-15-59

[AndyScherzinger]

• Are we getting the template previews from the server? Would look nicer than if it's all the filetype icon :)

Yes, they are fetched from the server

• Is it possible to prefill the filename input with e.g. the template name, so then it would be "Meeting notes.md" with the cursor before the dot?

Great idea: Implemented with the latest commit. Prefilling is done in case:

• filename is empty
• filename equals "."+ the template's extension (so no filename provided)

[nextcloud-android-bot]

White-Light-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/8005-Screenshot-White-Light-20-39

[szaimen]

Hey, I've just tested the PR and it would be great if the template could be selected by default if only one is available => makes the creation of a new file much faster ;)

[AndyScherzinger]

Hey, I've just tested the PR and it would be great if the template could be selected by default if only one is available => makes the creation of a new file much faster ;)

Done with latest commit (just wait for the new QA build...) and also: Hides the template chooser if only one template exists, see also #5144 - cc @szaimen 👍 #8005 (comment)

[nextcloud-android-bot]

Blue-Light-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/8005-Screenshot-Blue-Light-21-44

[szaimen]

@AndyScherzinger thanks for directly implementing my review :)
Just not showing the template if only one template is available is a good idea but in this case, the header maybe should be changed to Create new file, than showing Choose template. Otherwise if that is too complicate or too much work, it could show the only template and select it by default.

Also I can sometimes reproduce an issue where the create button is grey e.g. by triggering creating a new file (without creating it, so that the popup is still open), locking my phone, unlocking it again and looking at the popup again -> the create button is grey now. In my feeling there are more ways to reproduce this issue...

[AndyScherzinger]

@szaimen my pleasure and thanks for testing. There will be 2 more QA builds in the next minutes which should address the title handling as well as the button 👍

[szaimen]

@AndyScherzinger really appreciated, thanks!
I am not sure if it is a translation issue but it says now "Neu erstellen Textdokument" bzw. "Neu erstellen Dokument" etc. in the header which sounds a bit strange to me. Otherwise it is perfect 👍

Also, but this should most likely get addressed with another PR: I am not able to create a new file from template when beeing in a folder that is mounted via the external storage app:

To reproduce:

1. Enable the external storage app on your server
2. Create a local external storage mount with the app and mount it to a user (and make it writeabel)
3. Open the android app, navigate into the external storage folder and try to create a file from template there -> error creating file from template

(But I need to say that this second issue is present since a while now and not new in this PR. I just thought it could make sense to show it since this PR addresses this part of the app)

[AndyScherzinger]

@szaimen yes,that is a translation issue already being discussed in another issue (same text as the bottom sheet!).

Same for the mount issue. Best to raise a new issue and ping @tobiasKaminsky about it.

And again, thanks for your testing efforts, highly appreciate it ❤️

[nextcloud-android-bot]

Blue-Dark-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/8005-Screenshot-Blue-Dark-08-01

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/8005.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

stable-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/702-IT-stable-13-29

[nextcloud-android-bot]

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/702-IT-master-13-30

[nextcloud-android-bot]

Codacy

Lint

Type	master	PR
Warnings	240	232
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	52
Internationalization Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	73
Security Warnings	40
Dodgy code Warnings	99
Total	309

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	52
Internationalization Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	73
Security Warnings	40
Dodgy code Warnings	99
Total	309