Uh oh!
There was an error while loading. Please reload this page.
feat: update translate task form layout - #232
Conversation
Signed-off-by: Edward Ly <contact@edward.ly>
Signed-off-by: Edward Ly <contact@edward.ly>
DaphneMuller
commented
May 5, 2025
I'm wondering if we want the user to select the model. Didn't we say in the past we let model selection be done by the admin? @julien-nc |
janepie
commented
May 5, 2025
This is hidden under "show advanced options" right now as we have it in every other task type |
You seem to not use the input shape defaults right now I think, it would be good to have them used as pre-set languages @edward-ly |
Signed-off-by: Edward Ly <contact@edward.ly>
edward-ly
commented
May 5, 2025
Thanks for the catch! That should be fixed now. |
…puts and TranslateForm to make the text fields react and show/hide the copy button Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
commented
May 6, 2025
Nice! I hope you don't mind: I added a fix to make the output text field show and hide the "copy" button when the value changes. I realized it was broken in the generic form as well because the wrong event was emitted in AssistantFormOutputs so i fixed this one too. |
julien-nc
left a comment
There was a problem hiding this comment.
2 potential small changes.
Otherwise, good to go 👍
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Julien Veyssier <julien-nc@posteo.net> Signed-off-by: Edward Ly <contact@edward.ly>
Resolves#216. Parts of the new custom translate form component are adapted from the translate modal in the Text app.