Uh oh!
There was an error while loading. Please reload this page.
Change how small number inputs are rendered - #237
Conversation
edward-ly
left a comment
There was a problem hiding this comment.
Some possible design improvements:
- Add an "active" attribute highlighting the button that was last clicked (or the default value when the form is opened).
- Add a "Custom" button which toggles the visibility of the input field (which would be hidden by default to avoid mixing input types). Clicking on one of the 1-5 buttons would also hide the input field.
…lt value Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
… reactive Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
43e7a08 to
e49ba51Comparejulien-nc
commented
May 15, 2025
@edward-ly Thanks for the feedback and suggestions. Both are implemented. It was a bit tricky to make the state reactive to outside changes, especially when typing into the "custom" input field. If you wanna type "11", you start by typing "1" and the value changes immediately and 1 is considered as not custom so the 1 button is highlighted and the input field disappears. Simple solution is to debounce the number input update event. Kooha-2025-05-15-11-42-04.webm |
janepie
left a comment
There was a problem hiding this comment.
Looks good! Cannot test with >4 pictures right now, because OpenAI has a max of 4 I think. Maybe something we could chunk in the future?
marcelklehr
commented
May 15, 2025
Looks good! |
If the field's default value is under 10, we render it like that:
refs #215