Skip to content

Fix: chat user instruction handling - #297

Merged
julien-nc merged 2 commits into
mainfrom
fix/chat-title
Jul 8, 2025
Merged

Fix: chat user instruction handling#297
julien-nc merged 2 commits into
mainfrom
fix/chat-title

Conversation

@janepie

@janepiejanepie commented Jul 8, 2025

Copy link
Copy Markdown
Member

fixes#296

@janepie
janepie requested a review from julien-ncJuly 8, 2025 14:46
@janepie
janepie requested a review from marcelklehrJuly 8, 2025 14:46
@janepiejanepie changed the title Fix: chat title generationFix: chat user instruction handlingJul 8, 2025

@julien-ncjulien-nc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +136 to +138
if ($userInstructions === '') {
$userInstructions = Application::CHAT_USER_INSTRUCTIONS;
}

@julien-ncjulien-ncJul 8, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already solved in #292. Let's avoid a conflict there, you can revert that.

@janepiejanepieJul 8, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't touch ChattyLLM. Did you mean another PR?

Comment threadlib/Controller/ChattyLLMController.php Outdated
janepie added 2 commits July 8, 2025 17:18
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
@julien-nc
julien-nc merged commit 02994df into mainJul 8, 2025
16 checks passed
@julien-nc
julien-nc deleted the fix/chat-title branch July 8, 2025 15:33
@janepiejanepie mentioned this pull request Aug 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chat title generation fails

3 participants

@janepie@julien-nc@marcelklehr