Uh oh!
There was an error while loading. Please reload this page.
feat: add core:audio2text:subtitles task type, register file action - #577
Conversation
43ab519 to
5284315Compare1f404c4 to
83024f3Compareedward-ly
commented
Jun 18, 2026
Question: do we want to try to maintain compatibility with NC 33 on the |
83024f3 to
7bddb9cCompareb803865 to
4e51314Comparejulien-nc
commented
Jun 24, 2026
I hope you don't mind, I added some changes
It is quite convenient to keep the compatibility with the last 2 or 3 NC versions. If we find a serious bug, we can publish one single release for all the supported NC versions. IMHO let's keep the compatibility with 33 for now. |
4e51314 to
907b7d8Compareedward-ly
commented
Jul 13, 2026
@julien-nc What's the status of this PR right now? Is there anything else that needs urgent fixing? |
Signed-off-by: Edward Ly <contact@edward.ly>
…will get in nextcloud/ocp soon use php 8.3 in phpunit action Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
907b7d8 to
006b28bCompareAssisted-by: OpenCode:GLM-5.2 Signed-off-by: Edward Ly <contact@edward.ly>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Registers a file action and adds support for the new
core:audio2text:subtitlestask type. TheOCP\TaskProcessing\TaskTypes\AudioToTextSubtitlesclass is imported conditionally to maintain compatibility with NC versions older than 35.To Fix
This does not seem to have any adverse affect on the tasks themselves, but when opening finished subtitles tasks, the browser currently reports a few errors in the console such as(done)GET https://nextcloud.local/ocs/v2.php/apps/assistant/api/v1/file/104/inforeturning a 404 status.Limitations
Currently, the Save this media button for output files automatically appends the
.srtextension for.srtfiles, but not for.vttfiles. This seems to be a limitation of the PHP Mimey package as it doesn't recognize thetext/vttMIME type.By contrast, the Download this media button automatically appends the
.vttextension for.vttfiles, but not for.srtfiles for me. Since the browser/OS looks to be doing the MIME type to extension conversion at that point, I'm not sure if there's anything we can do there.🤖 AI (if applicable)