Skip to content

Add improve button to text outputs to allow for iteration - #596

Merged
lukasdotcom merged 4 commits into
mainfrom
improve-task-type
Jul 14, 2026
Merged

Add improve button to text outputs to allow for iteration#596
lukasdotcom merged 4 commits into
mainfrom
improve-task-type

Conversation

@lukasdotcom

@lukasdotcomlukasdotcom commented Jun 30, 2026

Copy link
Copy Markdown
Member

Example in generate text:
image

It is on all text output fields right now. If you can think of some it shouldn't be on feel free to mention that.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
@marcelklehr

Copy link
Copy Markdown
Member

The button could read "Improve this text", so it's more clear what it does, perhaps? Otherwise, improve could also mean something like "help improve the assistant", etc.

Comment threadsrc/components/AssistantTextProcessingForm.vue Outdated
return {
providedCurrentTaskId: () => this.selectedTaskId,
streaming: () => this.streaming,
improveOutput: (content) => {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this should be done with an event (still listen and handle the event here), not by providing a callback to the child components. Wdyt?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seemed easier to not use events because I would need to pass them through all the components, but I've changed it now to use events.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use the Nextcloud event bus so the event does not have to be forwarded by every component.

Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
@lukasdotcom

Copy link
Copy Markdown
MemberAuthor

The button could read "Improve this text", so it's more clear what it does, perhaps? Otherwise, improve could also mean something like "help improve the assistant", etc.

Makes sense

Comment threadsrc/components/AssistantTextProcessingForm.vue Outdated
Comment threadsrc/components/fields/TextInput.vue
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>

@kyteinskykyteinsky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lukasdotcom
lukasdotcom merged commit 25f918e into mainJul 14, 2026
9 checks passed
@lukasdotcom
lukasdotcom deleted the improve-task-type branch July 14, 2026 12:38
@janepiejanepie mentioned this pull request Aug 4, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@lukasdotcom@marcelklehr@julien-nc@kyteinsky