Skip to content

Audio translation - #601

Merged
julien-nc merged 6 commits into
mainfrom
enh/noid/audio-translation
Jul 10, 2026
Merged

Audio translation#601
julien-nc merged 6 commits into
mainfrom
enh/noid/audio-translation

Conversation

@julien-nc

@julien-ncjulien-nc commented Jul 8, 2026

Copy link
Copy Markdown
Member
  • Add an audio translation provider that runs 3 sub tasks (stt, translate, tts)
  • Proxy the optional input shape of the underlying translate and tts providers (if there are some known ones)
  • Bump min NC to 35
  • Set Php 8.3 in config.platform
  • Update composer dependencies

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…s of the audio translation provider
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc
julien-nc requested a review from janepie as a code ownerJuly 8, 2026 12:39
@julien-ncjulien-nc added enhancement New feature or request 3. to review labels Jul 8, 2026
@julien-nc
julien-ncforce-pushed the enh/noid/audio-translation branch from 5307384 to a71e365CompareJuly 8, 2026 12:41

@lukasdotcomlukasdotcom left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test this, but looks fine.

Comment threadlib/AppInfo/Application.php Outdated
…pendencies, run cs:fix
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc
julien-ncforce-pushed the enh/noid/audio-translation branch from a71e365 to 8941f14CompareJuly 8, 2026 15:56
// $context->registerTaskProcessingTaskType(ImageToTextTranslateTaskType::class);
// $context->registerTaskProcessingProvider(ImageToTextTranslateProvider::class);

$context->registerTaskProcessingProvider(AudioToAudioTranslateProvider::class);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we only register this if all subordinate task types have a provider available? Otherwise getPreferredTaskType throws

@julien-ncjulien-ncJul 9, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried

$availableTaskTypeIds = $this->taskProcessingManager->getAvailableTaskTypeIds();
if (in_array(AudioToText::ID, $availableTaskTypeIds, true)) {
$context->registerTaskProcessingProvider(AudioToAudioTranslateProvider::class);
}

but at this point not all the task types are registered, on my setup I only get core:audio2audio:chat and assistant:text2sticker. Not sure if we can really check what's available here.

Comment threadlib/TaskProcessing/AudioToAudioTranslateProvider.php Outdated
Comment threadlib/TaskProcessing/AudioToAudioTranslateProvider.php Outdated
Comment threadlib/TaskProcessing/AudioToAudioTranslateProvider.php Outdated
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Comment threadlib/TaskProcessing/AudioToAudioTranslateProvider.php Outdated
… AudioToAudioTranslateProvider
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc
julien-nc merged commit a342c0c into mainJul 10, 2026
14 checks passed
@julien-nc
julien-nc deleted the enh/noid/audio-translation branch July 10, 2026 09:04
@janepiejanepie mentioned this pull request Aug 4, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewenhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@julien-nc@marcelklehr@lukasdotcom