Skip to content

Make psalm run on pushes to protected branches - #1131

Merged
skjnldsv merged 1 commit into
masterfrom
nickvergessen-patch-1
Aug 18, 2022
Merged

Make psalm run on pushes to protected branches#1131
skjnldsv merged 1 commit into
masterfrom
nickvergessen-patch-1

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Signed-off-by: Joas Schilling 213943+nickvergessen@users.noreply.github.com

Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
@skjnldsv

Copy link
Copy Markdown
Member

@skjnldsv
skjnldsv merged commit 1197780 into masterAug 18, 2022
@delete-merged-branch
delete-merged-branchBot deleted the nickvergessen-patch-1 branch August 18, 2022 07:50
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

Wut, it passes? https://github.com/nextcloud/circles/runs/7877169613?check_suite_focus=true

Yeah because it used the old lib because #1133 was not there. it didn't reinstall newest master?

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

Also I was refering to pushes, not PRs/merges.
E.g. Translations which therefor run psalm on a regular basis:
https://github.com/nextcloud/circles/actions/workflows/static-analysis.yml

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@nickvergessen@skjnldsv