Skip to content

fix: Remove fully_qualified_strict_types again - #16

Merged
nickvergessen merged 2 commits into
masterfrom
nickvergessen-patch-1
Feb 1, 2024
Merged

fix: Remove fully_qualified_strict_types again #16
nickvergessen merged 2 commits into
masterfrom
nickvergessen-patch-1

Conversation

@nickvergessen

@nickvergessennickvergessen commented Feb 1, 2024

Copy link
Copy Markdown
Member

fully_qualified_strict_types => leading_backslash_in_global_namespace we want to use was only introduced with 3.46 PHP-CS-Fixer/PHP-CS-Fixer@0061223

@nickvergessennickvergessen self-assigned this Feb 1, 2024
@nickvergessen

nickvergessen commented Feb 1, 2024

Copy link
Copy Markdown
MemberAuthor

Broke the update in notifications, works after bumping cs-fixer as well:
https://github.com/nextcloud/notifications/pull/1807/files#diff-f37acfaa6b11f575a9a6f41a75fa73a61d0f8ebc2c9b8cddc215d8aca10e44f5L1132-R1132

come-nc
come-nc previously approved these changes Feb 1, 2024
View reviewed changes

@come-nccome-nc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New minor release with changelog line?

come-nc
come-nc reviewed Feb 1, 2024
View reviewed changes
Comment threadcomposer.json
ChristophWurst
ChristophWurst previously approved these changes Feb 1, 2024
View reviewed changes
nickvergessenand others added 2 commits February 1, 2024 15:38
@nickvergessen
fix: Remove fully_qualified_strict_types again
51cf509
There are currently too many issues for the rule on the project itself
#17PHP-CS-Fixer/PHP-CS-Fixer#7719
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
@nickvergessen
fix(docs): Update old file name in readme
35fd40e
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen

nickvergessen commented Feb 1, 2024

Copy link
Copy Markdown
MemberAuthor

As per #17 we remove the rule for now again instead

@nickvergessennickvergessen changed the title Update required cs-fixer versionfix: Remove fully_qualified_strict_types again Feb 1, 2024
@come-nc

come-nc commented Feb 1, 2024

Copy link
Copy Markdown
Contributor

We may still want to update php-cs-fixer?

@nickvergessen

nickvergessen commented Feb 1, 2024

Copy link
Copy Markdown
MemberAuthor

We may still want to update php-cs-fixer?

It's not required anymore, so I prefer to not break things :-X

@nickvergessen
nickvergessen merged commit cf5f18d into masterFeb 1, 2024
@delete-merged-branch
delete-merged-branchBot deleted the nickvergessen-patch-1 branch February 1, 2024 14:54
@come-nc

come-nc commented Feb 1, 2024

Copy link
Copy Markdown
Contributor

We may still want to update php-cs-fixer?

It's not required anymore, so I prefer to not break things :-X

Yeah but then you’re not fixing things either

@nickvergessen

nickvergessen commented Feb 1, 2024

Copy link
Copy Markdown
MemberAuthor

Yeah but then you’re not fixing things either

No need to fix something that is not broken.

We can make a new version/branch with 2.0 requiring 8.0 and cs-fixer 3.48+ or something.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@come-nccome-nccome-nc approved these changes
@provokateurinprovokateurinAwaiting requested review from provokateurin

Assignees

@nickvergessennickvergessen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@come-nc@ChristophWurst