I gotta have more tools by marcelklehr · Pull Request #127 · nextcloud/context_agent

marcelklehr · 2026-03-11T11:12:44Z

@janepie maybe we can share reviewing and testing these together?

Reviewed and tested works:

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Copilot

Pull request overview

This PR significantly expands the available “all_tools” integrations by adding new tool modules for multiple Nextcloud apps (e.g., Shares, Polls, Photos, Passwords, Notes, News, Music, Forms, Bookmarks, Circles, Cookbook) and extending existing tool sets (Files, Deck, Calendar, Mail).

Changes:

Add many new tool modules exposing Nextcloud app APIs via @tool functions (safe/dangerous).
Extend existing tools for Files (WebDAV ops + tags), Deck (card operations), Calendar (task operations), and Mail (folder/message helpers).
Introduce new per-app availability gating via is_available for most new modules.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
ex_app/lib/all_tools/shares.py	New sharing + groups tools (list/create/update/delete shares, group info)
ex_app/lib/all_tools/polls.py	New Polls tools (list, details, create/options/votes, close/reopen)
ex_app/lib/all_tools/photos.py	New Photos tools (albums CRUD, album membership changes, date search)
ex_app/lib/all_tools/passwords.py	New Passwords tools (folders, search/list, CRUD incl. secret retrieval)
ex_app/lib/all_tools/notes.py	New Notes tools (list/get/create/update/delete + client-side search)
ex_app/lib/all_tools/news.py	New News/RSS tools (feeds/folders/items + mark read/unread)
ex_app/lib/all_tools/music.py	New Music tools (library browsing/search + playlist CRUD)
ex_app/lib/all_tools/forms.py	New Forms tools (list/details/create/questions/responses/settings)
ex_app/lib/all_tools/bookmarks.py	New Bookmarks tools (list/search + bookmark/folder/tag management)
ex_app/lib/all_tools/circles.py	New Circles/Teams tools (CRUD circles + membership + share to circle)
ex_app/lib/all_tools/cookbook.py	New Cookbook tools (recipes CRUD + categories + search)
ex_app/lib/all_tools/files.py	Adds WebDAV file ops + file tagging tools
ex_app/lib/all_tools/deck.py	Expands Deck tooling for card lifecycle, labels, assignments, comments
ex_app/lib/all_tools/calendar.py	Adds task list/complete/update/delete tools (CalDAV todos)
ex_app/lib/all_tools/mail.py	Adds folder listing, message listing/search, move/delete helpers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

…_agent into copilot/test-new-tools-in-pr-127

- deck.py: Fix list_boards() returning response.text instead of response.json() - mail.py: Fix wrong docstring on get_mail_account_list(), rewrite list_mail_folders, search_emails, get_email_messages, move_email_to_folder, delete_email to use correct Nextcloud Mail REST API routes instead of nonexistent OCS routes - polls.py: Fix all routes to include correct /api/v1.0/ prefix, fix create_poll payload (API doesn't accept description), fix add_poll_option payload structure, fix vote_on_poll to use correct URL-based answer format - forms.py: Update from nonexistent v2.4 API to correct v3 API, fix create_form to use two-step create+update pattern, fix add_question_to_form payload, fix option creation to use batch optionTexts parameter - files.py: Fix get_folder_tree to use params= instead of json= for GET request Co-authored-by: marcelklehr <986878+marcelklehr@users.noreply.github.com>

Nextcloud's SecurityMiddleware enforces CSRF checks on controller methods without @NoCSRFRequired. ExApps don't have CSRF tokens, but Nextcloud's Request::passesCSRFCheck() bypasses CSRF if the OCS-APIREQUEST header is present (any non-empty value). The nc_py_api library sets this header on the main OCS adapter, but NOT on fresh adapters created via _create_adapter(True) used for REST calls. Added "OCS-APIREQUEST": "true" header to all non-DAV REST API calls in: bookmarks, cookbook, deck, mail, music, news, passwords, photos. DAV calls (files.py, contacts.py, calendar.py) use /remote.php/dav/ which goes through Sabre auth (AppAPIAuthBackend), not the CSRF middleware. OCS calls (forms.py, polls.py, notes.py, circles.py, shares.py) already have CSRF bypass via the OCS adapter's built-in OCS-APIREQUEST header. Co-authored-by: marcelklehr <986878+marcelklehr@users.noreply.github.com>

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Signed-off-by: Marcel Klehr <mklehr@gmx.net> # Conflicts: # ex_app/lib/all_tools/bookmarks.py # ex_app/lib/all_tools/circles.py # ex_app/lib/all_tools/cookbook.py

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

marcelklehr · 2026-03-23T10:10:58Z

@janepie I dropped all changes that didn't work and or I didn't have the motivation to test, everything in here should now work

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

julien-nc · 2026-03-25T00:01:13Z

Deck add card
Deck assign card (impossible to target an existing card by name, it only works right after a card has been added so the agent knows its ID, there could be a "list board cards" tool with an optional list ID param)
Delete card

Wdyt about the "list board cards" tool?

I occasionally got something like messages with role 'tool' must be a response to a preceeding message with 'tool_calls' (with OpenAI + GPT 4.1) or No tool call found for function call output with call_id call_1t4CeDkPZAlWVXMBiNdGbj4d (with OpenRouter + GPT 4.1). It's easy to reproduce but i don't have a clear procedure.

Last time it happened, I just did:

list the cards in all lists of the NAME board
assign card 8 to the admin user
delete card 7

And the "chat with tools" task failed because the request response was messages with role 'tool' must be a response to a preceeding message...

marcelklehr · 2026-03-25T07:55:36Z

I occasionally got something like messages with role 'tool' must be a response to a preceeding message with 'tool_calls'

Can you check if this happens with the main branch as well?

julien-nc · 2026-03-25T09:39:36Z

Same with main, it seems i'm consistently getting this error after a fixed number of tool calls. I had the same session multiple times:

list my talk conversations
what is the weather in Paris?
list my deck boards
what is the weather in Berlin?

And I always got the error for the last message.

julien-nc · 2026-03-25T11:14:56Z

Tools in files.py ✔️

I could see the new tools after registering the app again.

Sharing ✔️

marcelklehr · 2026-03-25T12:28:40Z

Deck assign card (impossible to target an existing card by name, it only works right after a card has been added so the agent knows its ID, there could be a "list board cards" tool with an optional list ID param)

Works for me, it can use the search tool

julien-nc · 2026-03-25T12:44:58Z

Works for me, it can use the search tool

Now I have the tools. All good.

Extend the Deck tool module with one discovery tool and four comment tools, together addressing a gap where the agent could not target existing cards by name or interact with card discussions. Card discovery (1 tool): - list_board_cards: list all cards in a board with metadata (stack, labels, assignees, due date, archived status, done, comments count). Optional stack_id filter limits to a single stack. Fills the gap raised in nextcloud#127 where add_card, add_card_label, assign_card_to_user, and delete_card all require a card_id the agent otherwise cannot discover (the unified search tool works for keyword lookups but does not enumerate and does not return structured metadata). Card comments (4 tools): - list_card_comments: list all comments on a card with pagination - add_card_comment: create a comment, with optional threaded reply support - update_card_comment: edit an existing comment (author-only) - delete_card_comment: remove a comment (author-only) list_board_cards uses the existing /boards/{boardId}/stacks REST endpoint via the adapter pattern consistent with the other Deck tools, and flattens the nested stack-cards shape for agent use while stripping internal fields (ETag, lastModified, order, etc.). Comments use the Deck OCS API via nc.ocs(), consistent with how shares.py and other OCS-based tools work. The existing board/card tools (REST API) are unchanged except for docstring corrections pointing card_id lookups at list_board_cards instead of list_boards (which does not return cards). Tested against Nextcloud 32.0.8 with Deck 1.16.4. Signed-off-by: Pavlinchen <paulm.schmidt@icloud.com>

marcelklehr added 15 commits March 11, 2026 12:09

feat: Implement bookmarks app tools
c24bdde
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

feat: Implement tools related to tasks
e5b6480
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

feat: Implement tools related to circles
891b330
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

feat: Implement tools for the cookbook app
9c49ec8
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

feat: Implement more tools for deck
3303b52
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

feat: Implement more tools for files
293514b
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

feat: Implement tools for the forms app
7bc16c9
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

feat: Implement more tools for the mail app
a275b9a
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

feat: Implement tools for the music app
e2657ec
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

feat: Implement tools for the news app
c1678cd
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

feat: Implement tools for the notes app
e3c6509
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

feat: Implement tools for the passwords app
0e9de90
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

feat: Implement tools for photo albums
ab24c37
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

feat: Implement tools for the polls app
f41a132
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

feat: Implement tools for sharing
1b1d20b
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

marcelklehr requested review from Copilot and janepie March 11, 2026 11:12

Copilotstarted reviewing on behalf of marcelklehr March 11, 2026 11:13 View session

CopilotAI reviewed Mar 11, 2026
View reviewed changes

Comment threadex_app/lib/all_tools/shares.py
Comment threadex_app/lib/all_tools/forms.py
Comment threadex_app/lib/all_tools/passwords.py Outdated
Comment threadex_app/lib/all_tools/notes.py Outdated
Comment threadex_app/lib/all_tools/news.py Outdated
Comment threadex_app/lib/all_tools/shares.py

marcelklehrand others added 2 commits March 11, 2026 14:47

fix(calendar): Fix new tasks tools to use ics library
374a5ea
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Initial plan
b8a9d30

CopilotAI mentioned this pull request Mar 17, 2026
Fix broken API routes and add CSRF bypass for ExApp REST calls #132
Closed
14 tasks

CopilotAIand others added 8 commits March 17, 2026 22:07

Merge branch 'feat/moartools' ofhttps://github.com/nextcloud/context…
64e674c
…_agent into copilot/test-new-tools-in-pr-127

fixes
9121c5f
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

remove bookmarks
e3e6877
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix(circles): always return strings
3c236d1
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Merge branch 'feat/moartools' into copilot/test-new-tools-in-pr-127
159920b
Signed-off-by: Marcel Klehr <mklehr@gmx.net> # Conflicts: # ex_app/lib/all_tools/bookmarks.py # ex_app/lib/all_tools/circles.py # ex_app/lib/all_tools/cookbook.py

fix(deck): Fix deck tools
c1a3799
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

marcelklehr added 3 commits March 23, 2026 10:10

fix(files): Fix files tools
6c1f6f1
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fixes
4d77b45
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix(mail): remove useless changes
ec46c47
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

marcelklehr added 2 commits March 23, 2026 12:30

feat: Implement bookmarks tools
75cf699
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

tests: Increase wait time for task processing
e58eb55
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

marcelklehr requested a review from julien-nc March 24, 2026 10:47

fix(nc_model): Increase timeout to 30 minutes
6ffacb5
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

julien-nc approved these changes Mar 25, 2026
View reviewed changes

marcelklehr merged commit bc27b12 into mainMar 25, 2026
6 checks passed

marcelklehr deleted the feat/moartools branch March 25, 2026 13:02

Pavlinchen mentioned this pull request Apr 22, 2026
feat(deck): Add list_board_cards tool for card discovery #158
Closed
8 tasks

Pavlinchen mentioned this pull request Apr 22, 2026
feat(deck): Add card discovery (list_board_cards) and card comment tools #155
Merged
14 tasks

Navigation Menu

Uh oh!

I gotta have more tools - #127

I gotta have more tools#127
marcelklehr merged 31 commits into
mainfrom
feat/moartools

marcelklehr commented Mar 11, 2026•
edited
Loading

Uh oh!

CopilotAI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marcelklehr commented Mar 23, 2026

Uh oh!

julien-nc commented Mar 25, 2026

Uh oh!

marcelklehr commented Mar 25, 2026

Uh oh!

julien-nc commented Mar 25, 2026

Uh oh!

julien-nc commented Mar 25, 2026•
edited
Loading

Uh oh!

marcelklehr commented Mar 25, 2026

Uh oh!

julien-nc commented Mar 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

marcelklehr commented Mar 11, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marcelklehr commented Mar 23, 2026

Uh oh!

julien-nc commented Mar 25, 2026

Uh oh!

marcelklehr commented Mar 25, 2026

Uh oh!

julien-nc commented Mar 25, 2026

Uh oh!

julien-nc commented Mar 25, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcelklehr commented Mar 25, 2026

Uh oh!

julien-nc commented Mar 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

marcelklehr commented Mar 11, 2026•
edited
Loading

julien-nc commented Mar 25, 2026•
edited
Loading