clone stacks by jakobroehrl · Pull Request #1777 · nextcloud/deck

jakobroehrl · 2020-04-29T11:01:21Z

Signed-off-by: Jakob Röhrl jakob.roehrl@web.de

Resolves: clone a stack #1776
Target version: master

Todo / to clarify

Ideally we get the number of stacks in total for the board and move it to the end.
We could use the card clone implementation and use it here, too: Clone / Copy boards [$150] #119 (comment)
labels and assigned users clone
I think it should also work to just operate on $card directly so you just overwrite the properties that need to be changed and then passed to insert afterwards.

Labels are only shown after page reload
User assignment doesn't work: "The user is not part of the board"
https://github.com/nextcloud/deck/blob/0dd38f5f2e067ef78aa7dbf3cfc8cb61c6d2d6ca/lib/Service/StackService.php#L451-L455

jakobroehrl · 2020-04-30T09:22:56Z

@juliushaertl
We could use the card clone implementation and use it here, too: #119 (comment)
What do you think?

stefan-niedermann · 2020-05-09T12:03:24Z

Please have a look at #1832 before you make exact clones of the cards @jakobroehrl (Not sure if this affects this issue, sorry for spam if not)

juliusknorr · 2020-05-14T09:29:18Z

Sign in to view

+ $newStack = new Stack();
+ $newStack->setTitle($stack->getTitle() . ' (' . $this->l10n->t('copy') . ')');
+ $newStack->setBoardId($boardId);
+ $newStack->setOrder($stack->getOrder() +1);


Ideally we get the number of stacks in total for the board and move it to the end.

OK. This way I'll get the corresponding board:
$board = $this->boardMapper->find($boardId);
How can I get the stack number of this board?

juliusknorr · 2020-06-10T09:05:59Z

No need for that, you should be able to just remove the whole insert method and it will use the parent one then.

jakobroehrl · 2020-06-18T09:22:59Z

Works great!
Let's merge this in, so I can work on the board clone and card clone topics:

Sign in to view

+ $newStack = new Stack();
+ $newStack->setTitle($stack->getTitle() . ' (' . $this->l10n->t('copy') . ')');
+ $newStack->setBoardId($boardId);
+ $newStack->setOrder($stack->getOrder() +1);


juliusknorr · 2020-09-02T06:23:00Z

+ * @return array|Entity
+ */
+	public function find($cardId) {
+ $sql = 'SELECT * from `*PREFIX*deck_assigned_labels` where `card_id` = ?';


Could be switched to QBMapper right away to get rid of the deprecated DeckMapper. See https://docs.nextcloud.com/server/18/developer_manual/app/storage/database.html?highlight=querybuilder#mappers for an example

Feel free to do that in a follow up, but it would be good to not introduce new code that uses legacy functions right away 😉

Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>

juliusknorr · 2020-09-08T07:54:27Z

Tests fail 😉

Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>

doodhout · 2022-05-23T06:57:45Z

There was no reason given why this was never merged and then closed.

Is it possible to pick this up again, by the original committer or by someone else?

agautheron · 2024-11-08T18:16:05Z

Is it possible to pick this up again, by the original committer or by someone else?

@juliusknorr ?

jakobroehrl added enhancement 2. developing labels Apr 29, 2020

jakobroehrl added this to the ⭐ 1.1.0 milestone Apr 29, 2020

jakobroehrl requested a review from juliusknorr April 29, 2020 11:01

jakobroehrl self-assigned this Apr 29, 2020