Skip to content

archive all cards from stack - #1853

Merged
juliusknorr merged 4 commits into
masterfrom
enh/archiveAllCardsFromStack
Aug 18, 2020
Merged

archive all cards from stack#1853
juliusknorr merged 4 commits into
masterfrom
enh/archiveAllCardsFromStack

Conversation

@jakobroehrl

@jakobroehrljakobroehrl commented May 11, 2020

Copy link
Copy Markdown
Contributor

Signed-off-by: Jakob Röhrl jakob.roehrl@web.de

grafik

Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
@juliusknorr

This comment has been minimized.

Comment threadsrc/components/board/Stack.vue Outdated
@stefan-niedermann

Copy link
Copy Markdown
Member

I would switch the entries, like in the boards menu:

grafik

In general we should put the most destructive operations (delete in this case) always at the bottom (Files app does this, too).

@jakobroehrl
jakobroehrlforce-pushed the enh/archiveAllCardsFromStack branch from 0cea1c3 to 7e24cc9CompareMay 13, 2020 10:23
@jakobroehrl

Copy link
Copy Markdown
ContributorAuthor

In general we should put the most destructive operations (delete in this case) always at the bottom (Files app does this, too).

done

Comment threadsrc/components/board/Stack.vue Outdated
Comment threadsrc/components/board/Stack.vue Outdated
Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
Comment threadsrc/components/board/Stack.vue Outdated
Comment threadsrc/components/board/Stack.vue Outdated
Comment threadsrc/components/board/Stack.vue Outdated
Comment threadsrc/components/board/Stack.vue Outdated
Comment on lines +144 to +145
archiveAllCardsProgress: null,
stackLen: 0,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets group those into an object:

stackTransfer: {
total: 0,
current: null,
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakobroehrl What about this?

Comment threadsrc/components/board/Stack.vue Outdated

@juliusknorrjuliusknorr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline

Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
@jakobroehrl
jakobroehrlforce-pushed the enh/archiveAllCardsFromStack branch from cefc792 to dea358eCompareAugust 18, 2020 06:09

@juliusknorrjuliusknorr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this 👍

@juliusknorr
juliusknorr merged commit c0bfba7 into masterAug 18, 2020
@juliusknorr
juliusknorr deleted the enh/archiveAllCardsFromStack branch August 18, 2020 06:17
@juliusknorrjuliusknorr mentioned this pull request Sep 1, 2020
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to archive all tasks in a column?

3 participants

@jakobroehrl@juliusknorr@stefan-niedermann