Uh oh!
There was an error while loading. Please reload this page.
Unified search implementation - #2200
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
juliusknorr
commented
Aug 21, 2020
MemberAuthor
Pushed a fix for that. |
jakobroehrl
commented
Aug 21, 2020
Contributor
Now the search is working for the card title, card description, board name |
juliusknorr
commented
Aug 24, 2020
MemberAuthor
Let's do this in a follow-up as it it less urgent imo. Implementation can be based on https://github.com/juliushaertl/server/blob/2c699e090179a2ca235d28540b5999e27c36b9de/apps/comments/lib/Search/LegacyProvider.php#L66 and https://github.com/nextcloud/server/blob/ea8f68bea6957ae459ff1ba6849b25354b3f0093/apps/comments/lib/Search/CommentsSearchProvider.php |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
commented
Sep 1, 2020
MemberAuthor
Missing pieces for a follow up:
|
jakobroehrl
approved these changes
Sep 1, 2020
jakobroehrl
left a comment
Contributor
There was a problem hiding this comment.
This thing is working!
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.