Skip to content

ETag support for API endpoints - #2245

Merged
juliusknorr merged 6 commits into
masterfrom
enh/etag-api
Nov 10, 2020
Merged

ETag support for API endpoints#2245
juliusknorr merged 6 commits into
masterfrom
enh/etag-api

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Aug 29, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Implements a simplified version of #1650

  • ETag support for listing endpoints (board/stack)
  • ETag support for single object endpoints
  • Check individual modifying operations if they properly update the etag (last modified)
    • Comments do not update the last modified date yet

Follow up

  • ETag support for changing operations (ref Exclusive write access #925)
  • See if we need a separate field to store the etag so that it works somehow independent from the actual last modified date which is presented to the user
    • This would kind of make sense to not change the last modified date of a board, e.g. if a card was moved to the archive

cc @desperateCoder@stefan-niedermann

@juliusknorrjuliusknorr added this to the ⭐ 1.1.0 milestone Aug 31, 2020
This was referenced Sep 1, 2020
Merged
Merged
@juliusknorrjuliusknorr mentioned this pull request Sep 17, 2020
Merged
@juliusknorr

juliusknorr commented Oct 2, 2020

Copy link
Copy Markdown
MemberAuthor

@stefan-niedermann sorry but I'll need to move this to the next minor since lots of other stuff blocked me from working on this

@juliusknorrjuliusknorr modified the milestones: ⭐ 1.1.0, 1.1.1Oct 2, 2020
@juliusknorrjuliusknorr modified the milestones: 1.1.1, 1.1.2, 1.1.3Oct 13, 2020
@juliusknorrjuliusknorr modified the milestones: 1.1.3, 1.2.0Nov 9, 2020
@juliusknorr
Expose ETag on single object get methods
8b7a30c
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Update card modification date on label/user assignment changes
d916ef1
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Add documentation for ETags
6a8e607
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
juliusknorr marked this pull request as ready for review November 10, 2020 16:18
@juliusknorr
Expose etag through JSON responses for child elements
a46d31c
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Propagate ETag when comments are made
3fe849b
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Propagate ETag when an attachment is being marked as deleted
e16c561
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
juliusknorr merged commit 12ed9ae into masterNov 10, 2020
@juliusknorr
juliusknorr deleted the enh/etag-api branch November 10, 2020 20:58
@stefan-niedermann

stefan-niedermann commented Nov 10, 2020

Copy link
Copy Markdown
Member

@desperateCoder let's rock 'n' roll 🤘 🎸 🎵

@juliusknorrjuliusknorr mentioned this pull request Nov 16, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

2. developingenhancementfeature: api

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@juliusknorr@stefan-niedermann