Skip to content

Fix wrong SQL queries - #2278

Merged
juliusknorr merged 1 commit into
nextcloud:masterfrom
Chartman123:patch-1
Sep 10, 2020
Merged

Fix wrong SQL queries#2278
juliusknorr merged 1 commit into
nextcloud:masterfrom
Chartman123:patch-1

Conversation

@Chartman123

@Chartman123Chartman123 commented Sep 8, 2020

Copy link
Copy Markdown
Contributor

Add additional ', so that the resulting SQL query is correct

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@Chartman123

Copy link
Copy Markdown
ContributorAuthor

I've tested the fix on our Nextcloud and the error messages in the log files have gone.

@juliusknorr

Copy link
Copy Markdown
Member

Thanks a lot for the fix 👍

Mind to add a signoff message to your commit? :)

@Chartman123

Copy link
Copy Markdown
ContributorAuthor

Mind to add a signoff message to your commit? :)

Sorry... Is it possible to change the commit message or how can I add the signoff message?

@juliusknorr

Copy link
Copy Markdown
Member

You should be able to just signoff the last commit and do a force push with the following commands on your branch:

git commit --amend --signoff
git push -f

@Chartman123

Copy link
Copy Markdown
ContributorAuthor

You should be able to just signoff the last commit and do a force push with the following commands on your branch:

git commit --amend --signoff
git push -f

Ok, so I'll have to install git first... I edited the file and created the PR online directly in GitHub

Add additional ', so that the resulting SQL query is correct
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123

Copy link
Copy Markdown
ContributorAuthor

Apparently it worked ;-)

@juliusknorrjuliusknorr mentioned this pull request Sep 10, 2020
@juliusknorr
juliusknorr merged commit e48ff44 into nextcloud:masterSep 10, 2020
@Chartman123
Chartman123 deleted the patch-1 branch September 10, 2020 07:17
@juliusknorrjuliusknorr mentioned this pull request Sep 16, 2020
8 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong SQL Selects resulting from new code

3 participants

@Chartman123@juliusknorr@stefan-niedermann