Uh oh!
There was an error while loading. Please reload this page.
Reduce duplicate queries when fetching user boards an permissions - #3161
Merged
Conversation
juliusknorrforce-pushed
the
bugfix/sql-queries
branch
from
July 2, 2021 11:49
af1e0b8 to
5a566c0CompareUh oh!
There was an error while loading. Please reload this page.
juliusknorrforce-pushed
the
bugfix/sql-queries
branch
from
July 2, 2021 12:16
5a566c0 to
cb716eeComparenickvergessen
approved these changes
Jul 2, 2021
blizzz
reviewed
Jul 2, 2021
Member
There was a problem hiding this comment.
isset() is said to be faster, but there is a small difference –https://www.php.net/manual/en/function.array-key-exists.php example #2. For consideration.
blizzz
reviewed
Jul 2, 2021
Member
There was a problem hiding this comment.
could be also CappedMemoryCache to avoid overflow.
blizzz
reviewed
Jul 2, 2021
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
juliusknorrforce-pushed
the
bugfix/sql-queries
branch
from
July 5, 2021 07:57
80d2580 to
b4cee7fComparejuliusknorr
commented
Jul 5, 2021
MemberAuthor
/backport to stable22 |
juliusknorr
commented
Jul 5, 2021
MemberAuthor
/backport to stable1.4 |
juliusknorr
commented
Jul 5, 2021
MemberAuthor
Looking into the tests |
nickvergessen
approved these changes
Jul 5, 2021
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorrforce-pushed
the
bugfix/sql-queries
branch
from
July 5, 2021 17:53
b4cee7f to
ae2aa8cCompare
This was referenced Jul 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step to reduce the amounts of queries that happened during collecting incoming shares when setting up the filesystem for users.
Already gives quite some improvement in test setup with 1 shared board having 3 cards with a handful of attachments on each:
https://blackfire.io/profiles/compare/67ec272e-9530-491b-afb2-0fb2c9b06f59/graph