Skip to content

Adding Printing view, fixes #195 - #451

Closed
Dubidubiduu wants to merge 3 commits into
nextcloud:masterfrom
Dubidubiduu:Dubidubiduu-print
Closed

Adding Printing view, fixes #195#451
Dubidubiduu wants to merge 3 commits into
nextcloud:masterfrom
Dubidubiduu:Dubidubiduu-print

Conversation

@Dubidubiduu

@DubidubiduuDubidubiduu commented May 1, 2018

Copy link
Copy Markdown
Contributor
  • Hide navigation stuff
  • Printing first line of description
  • Breaking page after 6 stacks

Code works if it is pasted in style.scss but i don't got it to get imported in a separate file, maybe you have an idea...?!

Still don't know how to make it properly scale by default, so you still have to scale up, for example up to 200 % in Firefox.

Fix for #195

add print.scss
@DubidubiduuDubidubiduu changed the title Adding Printing viewAdding Printing view, fixes #195May 1, 2018
@codecov

codecovBot commented May 11, 2018

Copy link
Copy Markdown

Codecov Report

Merging #451 into master will decrease coverage by 3.54%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #451 +/- ##
==========================================
- Coverage 80.4% 76.85% -3.55% 
==========================================
Files 44 38 -6 Lines 1449 1175 -274 ==========================================
- Hits 1165 903 -262 + Misses 284 272 -12

@juliusknorr

Copy link
Copy Markdown
Member

Thank you very much @Dubidubiduu Can you try adding @import 'print.scss'; to the styles.scss file? That should just work fine.

Still don't know how to make it properly scale by default, so you still have to scale up, for example up to 200 % in Firefox.

Can you show me what looks wrong there, because to me the print view already looks ok so far 😉

@juliusknorrjuliusknorr added this to the 0.4.0 milestone May 11, 2018
@juliusknorrjuliusknorr modified the milestones: 0.4.0, BacklogJun 28, 2018
@juliusknorr

Copy link
Copy Markdown
Member

@Dubidubiduu Any news on this? Would be nice if we could at least have a first basic print stylesheet for now. :)

@Dubidubiduu
Dubidubiduu deleted the Dubidubiduu-print branch June 29, 2018 00:45
@Dubidubiduu
Dubidubiduu restored the Dubidubiduu-print branch June 29, 2018 01:17
@Dubidubiduu

Dubidubiduu commented Jun 29, 2018

Copy link
Copy Markdown
ContributorAuthor

@juliushaertl

Sorry for not pushing this forward. :-/

But now the truth is that I really need to get some sleep and I have my problems with using git, should read a tutorial or so, and on top I've got some nasty caching problems, which aren't solved yet. If you already could use those lines and it's not an act for you, you're very welcomed to just do it.

Otherwise it would take a few days to have some time to dig into this.

@DubidubiduuDubidubiduu mentioned this pull request Jun 29, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Dubidubiduu@juliusknorr