Uh oh!
There was an error while loading. Please reload this page.
Add notification on card assignment to user, fixes #475 - #545
Conversation
There was a problem hiding this comment.
Can you add a rich subject as well, similar to https://github.com/nextcloud/deck/pull/545/files#diff-52c5c003756b8dcc9c5318257107346dL95? This way the user will also be linked properly
juliusknorr
commented
Jul 23, 2018
Thank you very much for your pull request @steav, looks good besides the inline comment. Can you also remove the changes to the language files. We are managing translations via transifex and those strings will be pulled from there: https://www.transifex.com/nextcloud/nextcloud |
juliusknorr
commented
Jul 23, 2018
@steav Can you also add a sign-off message to the commits as described in https://github.com/nextcloud/deck#sign-your-work ? |
steav
commented
Jul 23, 2018
Thanks you a lot @juliushaertl for your advices and your awesome work! |
juliusknorr
commented
Jul 23, 2018
@steav Can you also have a look at the failing tests and add some basic ones for the new methods? |
There was a problem hiding this comment.
We should only send a notification if the user assigns somebody else. If you assign yourself, there is no need for a notification.
juliusknorr
commented
Jul 24, 2018
@steav Really nice work done here. Tested and works fine. I just have one small enhancement commented inline. After that it is good to go. 😉 |
Signed-off-by: Steav <steav8@gmail.com>
Signed-off-by: Steav <steav8@gmail.com>
Signed-off-by: Steav <steav8@gmail.com>
Signed-off-by: steav <steav8@gmail.com>
Signed-off-by: steav <steav8@gmail.com>
Signed-off-by: steav <steav8@gmail.com>
Signed-off-by: steav <steav8@gmail.com>
e2e832d to
476b15eCompare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
commented
Jul 28, 2018
merged. 🚀 Thank you very much for your contribution @steav Further pull requests are always welcome. 😉 |
No description provided.